Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Issue creating service principal on Azure. #2774

Closed
8 of 10 tasks
seriva opened this issue Dec 8, 2021 · 3 comments
Closed
8 of 10 tasks

[BUG] Issue creating service principal on Azure. #2774

seriva opened this issue Dec 8, 2021 · 3 comments
Assignees
Labels
priority/high Task with high priority provider/azure python Pull requests that update Python code type/bug

Comments

@seriva
Copy link
Collaborator

seriva commented Dec 8, 2021

Describe the bug
Under certain azure ad account creation of the service principle will fail with the message:

Values of IdentifierUris property must use a verified domain of the organization or its subdomain

Solution is to upgrade the version of azure-cli from 2.23 -> 2.29.0 (Not 2.31.0, see comment below.)

How to reproduce
Ask @przemyslavic or @seriva to create a cluster ... 😐

Expected behavior
Not to give this error 😐

Environment

  • Cloud provider: Azure
  • OS: All

Additional context
https://stackoverflow.com/questions/69591788/getting-hostnamenotonverifieddomain-when-setting-appid-uri-on-azure-ad-applica
https://docs.microsoft.com/en-us/azure/active-directory/develop/reference-breaking-changes#appid-uri-in-single-tenant-applications-will-require-use-of-default-scheme-or-verified-domains


DoD checklist

  • Changelog updated (if affected version was released)
  • COMPONENTS.md updated / doesn't need to be updated
  • Automated tests passed (QA pipelines)
    • apply
    • upgrade
  • Case covered by automated test (if possible)
  • Idempotency tested
  • Documentation updated / doesn't need to be updated
  • All conversations in PR resolved
  • Backport tasks created / doesn't need to be backported
@seriva seriva added type/bug provider/azure priority/high Task with high priority python Pull requests that update Python code labels Dec 8, 2021
@seriva seriva self-assigned this Dec 8, 2021
@przemyslavic
Copy link
Collaborator

✔️ Tested locally in devcontainer - created service principal without any issues.
✔️ Tested in the pipeline - deployed clusters with all components enabled.

@przemyslavic przemyslavic self-assigned this Dec 8, 2021
@seriva
Copy link
Collaborator Author

seriva commented Dec 10, 2021

Re-opening as Azure-cli 2.31.0 breaks non SP logins for our Terraform provider because of new token mechanism:

https://docs.microsoft.com/en-us/cli/azure/msal-based-azure-cli

2.29.0 does not have new token mechanism and it solves the problem described in this issue so downgrading from 2.31.0 to 2.29.0 again.

@przemyslavic
Copy link
Collaborator

Tested both devcontainer and epicli container:
✔️ use_service_principal: false
✔️ use_service_principal: true - creating a new service principal
✔️ use_service_principal: true - using an existing service principal

@seriva seriva closed this as completed Dec 14, 2021
@seriva seriva changed the title [BUG] Issue creating service principle on Azure. [BUG] Issue creating service principal on Azure. Jan 18, 2022
seriva added a commit that referenced this issue Jan 21, 2022
… (#2826)

* Backport #2784 for issue #2774
* Backport #2813 for issue #2768
* Backport #2823 for issue #2788
* Backport #2776 for issue #1221
* Backport #2442 for issue #2426
* Backport #2764 for issue #2744
* Backport issue #2831
* Backport #2912 for issue #2894
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/high Task with high priority provider/azure python Pull requests that update Python code type/bug
Projects
None yet
Development

No branches or pull requests

2 participants