Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PgBouncer standalone installation #2680

Closed
12 of 13 tasks
atsikham opened this issue Oct 8, 2021 · 4 comments
Closed
12 of 13 tasks

Remove PgBouncer standalone installation #2680

atsikham opened this issue Oct 8, 2021 · 4 comments
Assignees

Comments

@atsikham
Copy link
Contributor

atsikham commented Oct 8, 2021

Is your feature request related to a problem? Please describe.
We say in documentation that PgBouncer standalone installation is deprecated and will be removed.

Describe the solution you'd like

  1. Remove ability to specify this setting in configuration, modify schema
  2. Clean up Ansible configuration
  3. Update documentation

Describe alternatives you've considered

Additional context


DoD checklist

  • Changelog updated
  • COMPONENTS.md updated / doesn't need to be updated
  • Schema updated / doesn't need to be updated
  • Feature has automated tests
  • Automated tests passed (QA pipelines)
    • apply
    • upgrade
  • Idempotency tested
  • Documentation added / updated / doesn't need to be updated
  • All conversations in PR resolved
  • Solution meets requirements and is done according to design doc
  • Usage compliant with license
  • Backport tasks created / doesn't need to be backported
@mkyc mkyc changed the title Deprecate PgBouncer standalone installation Remove PgBouncer standalone installation Oct 22, 2021
@mkyc
Copy link
Contributor

mkyc commented Oct 22, 2021

Lets remember about very clear change log entry.

@to-bar
Copy link
Contributor

to-bar commented Dec 3, 2021

pgBouncer causes the following error when installing on Ubuntu 20.04 (Azure & AWS) on Extensions | PgBouncer | Restart systemd service task:

Dec  2 18:21:02 ci-devazurubuflannel-postgresql-vm-0 systemd[1]: Stopping LSB: start pgbouncer...
Dec  2 18:21:02 ci-devazurubuflannel-postgresql-vm-0 pgbouncer[25630]:  * Stopping PgBouncer pgbouncer
Dec  2 18:21:02 ci-devazurubuflannel-postgresql-vm-0 pgbouncer[25634]: start-stop-daemon: matching only on non-root pidfile /var/run/postgresql/pgbouncer.pid is insecure
Dec  2 18:21:02 ci-devazurubuflannel-postgresql-vm-0 pgbouncer[25630]:    ...fail!
Dec  2 18:21:02 ci-devazurubuflannel-postgresql-vm-0 systemd[1]: pgbouncer.service: Control process exited, code=exited, status=2/INVALIDARGUMENT
Dec  2 18:21:02 ci-devazurubuflannel-postgresql-vm-0 systemd[1]: pgbouncer.service: Failed with result 'exit-code'.
Dec  2 18:21:02 ci-devazurubuflannel-postgresql-vm-0 systemd[1]: Stopped LSB: start pgbouncer.
Dec  2 18:21:02 ci-devazurubuflannel-postgresql-vm-0 systemd[1]: pgbouncer.service: Found left-over process 24592 (pgbouncer) in control group while starting unit. Ignoring.
Dec  2 18:21:02 ci-devazurubuflannel-postgresql-vm-0 systemd[1]: Starting LSB: start pgbouncer...
Dec  2 18:21:02 ci-devazurubuflannel-postgresql-vm-0 pgbouncer[25635]:  * Starting PgBouncer pgbouncer
Dec  2 18:21:02 ci-devazurubuflannel-postgresql-vm-0 pgbouncer[25635]:    ...fail!
Dec  2 18:21:02 ci-devazurubuflannel-postgresql-vm-0 systemd[1]: pgbouncer.service: Control process exited, code=exited, status=2/INVALIDARGUMENT
Dec  2 18:21:02 ci-devazurubuflannel-postgresql-vm-0 systemd[1]: pgbouncer.service: Failed with result 'exit-code'.
Dec  2 18:21:02 ci-devazurubuflannel-postgresql-vm-0 systemd[1]: Failed to start LSB: start pgbouncer.

hence this task will be done before #1331.

@to-bar to-bar self-assigned this Dec 3, 2021
@przemyslavic przemyslavic self-assigned this Dec 9, 2021
@przemyslavic
Copy link
Collaborator

Looks like everything still works fine without pgbouncer 🐗

@seriva seriva closed this as completed Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants