You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
In our current setup we have a 2 stage build for the Epicli container. The first stage builds a Python package of Epicli which is then installed in the second stage inside the final docker image. This introduces a few issues:
Builds of the container take longer.
We have some of our code in the /data/ folder which is only needed because of the Python package:
Ansible code: /data/common/ansible
Spec tests: /data/common/tests
Terraform scripts: /data/aws/terraform, /data/azure/terraform
These locations are not intuitive when developing Epicli.
The Python package was meant to be distributed on the PyPi registry, however because of all the various dependencies we have, we now know this will never be the case.
Describe the solution you'd like
Remove the build of the PyPi package and add the needed folders directly to the image inside /epicli
Python dependencies can be installed directly using Pip and /.devcontainer/requirements.txt as in the devcontainer
Calling epicli as a command can be done using an alias as is done in devcontainer.
Restucture the /data folder to make more sense, contant of the folders will remain unchanged:
Move current content of /tests/ inside a subfolder /tests/unit and adjust the paths accordingly.
Move /data/common/tests content to /tests/spec and adjust the paths accordingly.
Move /data/common/ansible content to /ansible and adjust the paths accordingly.
Move /data/aws/terraform content to /terraform/aws and adjust the paths accordingly.
Move /data/azure/terraform content to /terraform/azure and adjust the paths accordingly.
Rename remaining /data folder to /schema is this will only contain defaults and validation files. Then adjust the paths accordingly.
Describe alternatives you've considered
None
Additional context
None
DoD checklist
Changelog updated
COMPONENTS.md updated / doesn't need to be updated
Schema updated / doesn't need to be updated
Feature has automated tests
Automated tests passed (QA pipelines)
apply
upgrade
Idempotency tested
Documentation added / updated / doesn't need to be updated
All conversations in PR resolved
Solution meets requirements and is done according to design doc
Usage compliant with license
Backport tasks created / doesn't need to be backported
The text was updated successfully, but these errors were encountered:
✔️ Successfully deployed Ubuntu/RHEL/CentOS clusters with all components enabled in the pipeline. Additionally, unit tests and spec tests were executed. Also tested in devcontainer.
- Removed legacy code for Epiphany < 0.3.
- Refactored build_saver.py and renamed to build_io.py as we do not only save.
- Updated tests to reflect all changes.
- Also added missing changelogs for #2643, #2666
- Added fixes for #2497 which where outstanding in #2652 and reported in: #2497 (comment)
Is your feature request related to a problem? Please describe.
In our current setup we have a 2 stage build for the Epicli container. The first stage builds a Python package of Epicli which is then installed in the second stage inside the final docker image. This introduces a few issues:
These locations are not intuitive when developing Epicli.
The Python package was meant to be distributed on the PyPi registry, however because of all the various dependencies we have, we now know this will never be the case.
Describe the solution you'd like
Describe alternatives you've considered
None
Additional context
None
DoD checklist
The text was updated successfully, but these errors were encountered: