Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Refactoring and removal of old code from Ansible inventory creator and upgrade #2547

Closed
13 tasks done
erzetpe opened this issue Sep 6, 2021 · 2 comments
Closed
13 tasks done
Assignees
Labels
python Pull requests that update Python code
Milestone

Comments

@erzetpe
Copy link
Contributor

erzetpe commented Sep 6, 2021

Is your feature request related to a problem? Please describe.
Right now we have the code that should be refactored from Ansible inventory creator and upgrade and some parts needs to be removed.

Describe the solution you'd like
We want to refactor and clean up the code from Ansible inventory creator and upgrade.

Describe alternatives you've considered
None.

Additional context
Code from the part BUILD_LEGACY upgrade should be removed.


DoD checklist

  • Changelog updated
  • COMPONENTS.md updated / doesn't need to be updated
  • Schema updated / doesn't need to be updated
  • Feature has automated tests
  • Automated tests passed (QA pipelines)
    • apply
    • upgrade
  • Idempotency tested
  • Documentation added / updated / doesn't need to be updated
  • All conversations in PR resolved
  • Solution meets requirements and is done according to design doc
  • Usage compliant with license
  • Backport tasks created / doesn't need to be backported
@erzetpe erzetpe added status/grooming-needed python Pull requests that update Python code labels Sep 6, 2021
@seriva seriva added this to the Improvements milestone Oct 6, 2021
@seriva seriva self-assigned this Oct 6, 2021
@seriva
Copy link
Collaborator

seriva commented Oct 8, 2021

@przemyslavic When testing this pls also run one upgrade. Not only for this but also #2643 and #2666.

@przemyslavic
Copy link
Collaborator

The following epicli commands have been tested:
✔️ init (--full)
✔️apply + re-apply
✔️backup
✔️recovery
✔️prepare
✔️test
✔️upgrade from v1.1 to dev
✔️delete

@mkyc mkyc closed this as completed Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests that update Python code
Projects
None yet
Development

No branches or pull requests

4 participants