Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UPGRADE] Upgrade component to the latest version: Zookeeper #1853

Closed
rafzei opened this issue Nov 16, 2020 · 12 comments
Closed

[UPGRADE] Upgrade component to the latest version: Zookeeper #1853

rafzei opened this issue Nov 16, 2020 · 12 comments
Assignees
Labels
area/kafka priority/high Task with high priority
Milestone

Comments

@rafzei
Copy link
Contributor

rafzei commented Nov 16, 2020

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

  • upgrade to latest version if possible
  • backport to supported Epiphany versions

Additional context
If possible, do an improvements in Zookeeper role. 👍

@rafzei rafzei added this to the S20201203 milestone Nov 16, 2020
@rafzei rafzei added the priority/high Task with high priority label Nov 16, 2020
@rafzei
Copy link
Contributor Author

rafzei commented Nov 19, 2020

Please verify if:

  • latest Kafka version contains embedded Zookeeper
  • we need a standalone Zookeeper (ask other teams)

@plirglo
Copy link
Contributor

plirglo commented Nov 24, 2020

Please see task #1137 - Kafka Upgrade.
We need upgrade Zookeeper to version supported by Kafka latest version:
Kafka 2.6.0 -> Zookeeper 3.5.8

After Kafka 3.0 release Zookeeper probably will not be needed for Kafka.

@mkyc
Copy link
Contributor

mkyc commented Nov 26, 2020

Lets upgrade to 3.5.8.

@rpudlowski93 rpudlowski93 self-assigned this Nov 30, 2020
@mkyc mkyc modified the milestones: S20201203, S20201217 Dec 4, 2020
@toszo
Copy link
Contributor

toszo commented Dec 8, 2020

Lets upgrade to 3.5.8.

@mkyc why 3.5.8 and not 3.6.2 - the latest one?

@mkyc
Copy link
Contributor

mkyc commented Dec 9, 2020

Hmmmm ... there was some reason @plirglo gave that version in discussion, but I do not remember that reason.

@rpudlowski93
Copy link
Contributor

Upgraded to 3.5.8 done in PR #1897

@rpudlowski93
Copy link
Contributor

rpudlowski93 commented Dec 9, 2020

@plirglo Can You comment why to version 3.5.8 not to latest one? I think that the information in kafka release was leading the decision : link Zookeeper in latest version 3.6.2 could be nice . @plirglo Do You have any significant knowledge about it? If not I can make upgrade to latest version in mentioned PR #1897

@rafzei
Copy link
Contributor Author

rafzei commented Dec 15, 2020

After the discussion about the target version, can we backport this change to previous Epi versions?

@przemyslavic przemyslavic self-assigned this Dec 17, 2020
@plirglo
Copy link
Contributor

plirglo commented Dec 17, 2020

@rpudlowski93 I just based on Kafka documentation link, where stands that Kafka 2.6.0 goes with Zookeeper 3.5.8. Maybe Zookeeper 3.6.2 also will be compatible, but 'm not sure and we need additional test if we want to use this version.

@rpudlowski93
Copy link
Contributor

In my opinion, we can stay with 3.5.8 how the documentation say, PR for the upgrade was already merged.
If we would love to have the latest version it could be a easy/fast change but we would need some additional tests for it.

@rafzei Yes, we can backport it to previous version of epiphany but only when upgrade Kafka is backported. It should go together. Kafka 2.6.0 must work with Zookeeper in at least 3.5.8 version.

@rafzei
Copy link
Contributor Author

rafzei commented Dec 17, 2020

@rpudlowski93 I will create issues to backport Kafka.

@mkyc mkyc modified the milestones: S20201217, S20201231 Dec 17, 2020
@przemyslavic
Copy link
Collaborator

Checked:
epicli apply
epicli upgrade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kafka priority/high Task with high priority
Projects
None yet
Development

No branches or pull requests

6 participants