Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Use built-in Prometheus exporter in HAProxy 2.2 #1739

Closed
9 of 10 tasks
sk4zuzu opened this issue Oct 6, 2020 · 2 comments
Closed
9 of 10 tasks

[FEATURE REQUEST] Use built-in Prometheus exporter in HAProxy 2.2 #1739

sk4zuzu opened this issue Oct 6, 2020 · 2 comments

Comments

@sk4zuzu
Copy link
Contributor

sk4zuzu commented Oct 6, 2020

Is your feature request related to a problem? Please describe.
We recently upgraded HAProxy in Epiphany. We still use old solution for exporting HAProxy metrics to Prometheus though... :'C

Describe the solution you'd like
BLOG POST: https://www.haproxy.com/blog/haproxy-exposes-a-prometheus-metrics-endpoint/

Our new HAProxy solution seems to have Prometheus plugin compiled-in https://github.com/docker-library/haproxy/blob/34f7b69c09fa0f16a0834641aa6556523c67b1ed/2.2/alpine/Dockerfile#L40 👍😇

How about migrating to compiled-in exporter? 🤔

Describe alternatives you've considered
We could do nothing! :trollface:

Additional context
N/A


DoD checklist

  • Changelog updated (if affected version was released)
  • COMPONENTS.md updated / doesn't need to be updated
  • Automated tests passed (QA pipelines)
    • apply
    • upgrade
  • Case covered by automated test (if possible)
  • Idempotency tested
  • Documentation updated / doesn't need to be updated
  • All conversations in PR resolved
  • Backport tasks created / doesn't need to be backported
@sk4zuzu sk4zuzu changed the title [FEATURE REQUEST] Use built-in prometheus exporter in HAProxy 2.2 [FEATURE REQUEST] Use built-in Prometheus exporter in HAProxy 2.2 Oct 6, 2020
@rafzei
Copy link
Contributor

rafzei commented Dec 3, 2021

It's well described in the blog post.

Ps. Now its time to stop do nothing :trollface:

@przemyslavic
Copy link
Collaborator

przemyslavic commented Jan 5, 2022

Tested scenarios:
✔️ epicli apply -> epicli apply (x86_64 and aarch64)
✔️ epicli apply v1.0.1 -> epicli upgrade -> epicli upgrade (x86_64)
✔️ epicli apply v1.2.0 -> epicli upgrade -> epicli upgrade (aarch64)
✔️ Verified HAProxy metrics in Prometheus and Grafana.

@seriva seriva closed this as completed Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants