Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Build epicli image using Dockerfile only (without shell script) #1609

Closed
to-bar opened this issue Sep 2, 2020 · 3 comments

Comments

@to-bar
Copy link
Contributor

to-bar commented Sep 2, 2020

Is your feature request related to a problem? Please describe.
To build epicli Docker image we use the build-docker.sh shell script. It builds epicli wheel file (distribution package) which is used (copied) in the Dockerfile. The build script has no support for any docker build parameters (like tags or labels) and always creates the epicli image tagged as latest. This requires another task in the build pipeline to tag the image using the target tag. In case of parallel builds there is a risk that the tagging task will label not the right image.

Describe the solution you'd like
Build epicli wheel file as a part of Dockerfile (using multistage builds feature) instead of wrapper script.

@mkyc
Copy link
Contributor

mkyc commented Sep 2, 2020

Please remember also about:

  • documentation update
  • after finish implementation create back port tasks

@to-bar to-bar changed the title [FEATURE REQUEST] Build Epiphany image using Dockerfile only (without shell script) [FEATURE REQUEST] Build epicli image using Dockerfile only (without shell script) Sep 2, 2020
@to-bar
Copy link
Contributor Author

to-bar commented Sep 3, 2020

Please remember also about:

* after finish implementation create back port tasks

Decided with @przemyslavic to not backport this feature to support branches.

@przemyslavic przemyslavic self-assigned this Sep 4, 2020
@przemyslavic
Copy link
Collaborator

Changes have been tested. The docker image is built correctly both locally and in the CI pipeline. The devcontainer was also rebuilt and no problems were encountered. It was decided not to backport this as it is more of an improvement/feature than a critical fix.

@mkyc mkyc closed this as completed Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants