Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper documentation how to define additional security rules for AWS/Azure #1322

Closed
seriva opened this issue Jun 3, 2020 · 8 comments · Fixed by #1714
Closed

Add proper documentation how to define additional security rules for AWS/Azure #1322

seriva opened this issue Jun 3, 2020 · 8 comments · Fixed by #1714
Assignees
Labels
area/docs Area for documentation improvement and addition type/improvement
Milestone

Comments

@seriva
Copy link
Collaborator

seriva commented Jun 3, 2020

Currently there is no documentation how to manage security rules for both AWS and Azure. In most cases teams are adding them manually through the clouds web interfaces or APIs resulting in Terraform wiping them out after re-running Epiphany.

Documentation (with example) should be written for both AWS and Azure showing:

  • Change existing default rules
  • How to add/extend rules

And should show how to do it so it does not break Epiphany features and support (e.g. still allows use of Epiphany tools to scale out the cluster, update it. etc.

@seriva seriva added this to the Improvements milestone Jun 3, 2020
@mkyc
Copy link
Contributor

mkyc commented Jul 7, 2020

looks like related to #896

@mkyc mkyc added the area/docs Area for documentation improvement and addition label Jul 7, 2020
@mkyc mkyc modified the milestones: Improvements, S20200827 Aug 7, 2020
@mkyc
Copy link
Contributor

mkyc commented Aug 27, 2020

We should add task (or check if there is one already) to adjust current defaults.

@mkyc mkyc modified the milestones: S20200910, S20200924 Aug 27, 2020
@ghost ghost removed the status/grooming-needed label Aug 28, 2020
@mkyc mkyc modified the milestones: S20200924, S20201008 Sep 10, 2020
@ghost ghost self-assigned this Sep 21, 2020
@ghost
Copy link

ghost commented Sep 28, 2020

Please note, that I stuck with this topic.

Cannot set the additional security rules in AWS, as none of configs provided by colleagues is working. If I need to document the procedure, first I need to have working solution (working yaml deployment file). Without that, it might be really hard to document, something what is not working

@seriva
Copy link
Collaborator Author

seriva commented Sep 30, 2020

Reviewed provided configuration: Azure was fine, AWS had port assigned to wrong field. Outstanding pull request to simplify the defaults and make them less confusing: #1714

@seriva seriva self-assigned this Sep 30, 2020
@seriva seriva linked a pull request Sep 30, 2020 that will close this issue
@ghost ghost assigned rafzei and unassigned rafzei Oct 1, 2020
@seriva seriva reopened this Oct 2, 2020
@mkyc
Copy link
Contributor

mkyc commented Oct 6, 2020

Is there any PR to be connected to this issue?

@ghost
Copy link

ghost commented Oct 7, 2020

@mkyc yes it is: #1717

@mkyc mkyc modified the milestones: S20201008, S20201022 Oct 8, 2020
@seriva
Copy link
Collaborator Author

seriva commented Oct 22, 2020

Tested with the configurations provided and everything works as expected.

@mkyc mkyc closed this as completed Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Area for documentation improvement and addition type/improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants