Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hex sticker #1004

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add hex sticker #1004

wants to merge 6 commits into from

Conversation

jamesmbaazam
Copy link
Contributor

@jamesmbaazam jamesmbaazam commented Feb 25, 2025

Description

This PR closes #791. See comments for alternatives.

What I need.

Upvote with a heart (❤️ ) and downvote with a thumbs down (👎🏾 ).

Leave comments on how elements of the most upvoted versions can be improved.

Initial submission checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have tested my changes locally (using devtools::test() and devtools::check()).
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required and rebuilt docs if yes (using devtools::document()).
  • I have followed the established coding standards (and checked using lintr::lint_package()).
  • I have added a news item linked to this PR.

After the initial Pull Request

  • I have reviewed Checks for this PR and addressed any issues as far as I am able.

@jamesmbaazam
Copy link
Contributor Author

jamesmbaazam commented Feb 25, 2025

logo

@jamesmbaazam jamesmbaazam requested review from seabbs and sbfnk February 25, 2025 16:24
@jamesmbaazam
Copy link
Contributor Author

@athowes comments welcome.

@athowes
Copy link

athowes commented Feb 25, 2025

Nice work @jamesmbaazam!

  • I could be wrong but the epidemic curve looks mismatched to the data? Could it be more on top? Or chose to display a quantity which looks more natural?
  • I'd suggest make plot bigger and don't leave any space below it (but that's just me)
  • That should allow text to be larger (perhaps)
  • Currently it looks perhaps slightly muted for my taste but again that's just me

@jamesmbaazam
Copy link
Contributor Author

jamesmbaazam commented Feb 26, 2025

Purple opt 1

purple_logo_purple_pname_big_plot

@jamesmbaazam
Copy link
Contributor Author

Purple opt 2

purple_logo_purple_pname_smaller_plot

@jamesmbaazam
Copy link
Contributor Author

jamesmbaazam commented Feb 26, 2025

Nice work @jamesmbaazam!

  • I could be wrong but the epidemic curve looks mismatched to the data? Could it be more on top? Or chose to display a quantity which looks more natural?

That's the latent infections mapped to reporting dates, so it shows that the reported cases are delayed (forward) and only a proportion of the true infections.

  • I'd suggest make plot bigger and don't leave any space below it (but that's just me)

I'm in favour of it too but it gets a bit tricky to fill up the white space below it since it's a hexagon so some of the figure is cut off. See alternatives below.

  • That should allow text to be larger (perhaps)
  • Currently it looks perhaps slightly muted for my taste but again that's just me

I agree. The text needs to be bolder. However, the resizing process also reduces the crispness of the text.

@jamesmbaazam
Copy link
Contributor Author

jamesmbaazam commented Feb 26, 2025

This option places the package name below the plot to balance out the awkwardness of the flat bottom of the plot. The curves in the plot complement the top corners of the hexagon.

logo

@jamesmbaazam
Copy link
Contributor Author

Purple alternative of the one in #1004 (comment)
logo (1)

@athowes
Copy link

athowes commented Feb 26, 2025

Here's a quick prototype for what I'd imagine:

image

I'd likely prefer the plot a little lower and the text down and as big as it can be. Let me know if you like this and I can refine / add code.

Possible improvements to this: make each colour 1/3rd of the width. Put the dashed line in the middle of the gap (or maybe remove)

@sbfnk
Copy link
Contributor

sbfnk commented Feb 27, 2025

These look great!

I do like your suggestion @athowes with the diagonal lettering and the plot filling more of the logo.

@jamesmbaazam
Copy link
Contributor Author

the plot filling more of the logo.

I'm not sure I like that because it reduces it to a random visual element (like a pattern) instead of communicating the use case of the package.

@jamesmbaazam
Copy link
Contributor Author

I also think the text should be horizontal, but that's my preference.

Looking forward to agreeing on something and getting this issue closed.

@athowes
Copy link

athowes commented Feb 27, 2025

IMO the key design criteria for stickers is like that of flags. Works at a distance. That's why I prefer the making everything fill space approach. For example to me this epinowcast logo verges on small. I agree straight text and communicating purpose of package are design criteria too. Up to y'all.

image

@jamesmbaazam
Copy link
Contributor Author

That's why I prefer the making everything fill space approach

I don't think it's a matter of filling up space more than it is of using up the space well. I agree with the distance thing but favicons are difficult to see already, so not the best example. We should definitely increase the font size but to do it proportionally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hex logo
3 participants