Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expected class of target_date in epinow() #921

Open
jamesmbaazam opened this issue Jan 10, 2025 · 1 comment
Open

Expected class of target_date in epinow() #921

jamesmbaazam opened this issue Jan 10, 2025 · 1 comment

Comments

@jamesmbaazam
Copy link
Contributor

Currently, it is expected to be a string. Why is that? I was expecting it to be a Date object.

Should we be more permissive and allow it to be either a string or a date and if the former, coerce it to a date object?

@sbfnk
Copy link
Contributor

sbfnk commented Jan 10, 2025

I think we could expect it to be a date as you suggest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants