Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to {cli} for messaging #546

Closed
sbfnk opened this issue Feb 14, 2024 · 2 comments · Fixed by #762
Closed

Move to {cli} for messaging #546

sbfnk opened this issue Feb 14, 2024 · 2 comments · Fixed by #762
Assignees
@jamesmbaazam
Milestone
CRAN v1.6 release

Comments

@sbfnk
Copy link
Contributor

sbfnk commented Feb 14, 2024

One reason to do so:

#534 (comment)
@jamesmbaazam jamesmbaazam self-assigned this Apr 30, 2024
@jamesmbaazam jamesmbaazam removed their assignment Jun 25, 2024
@jamesmbaazam
Copy link
Contributor

I just came across this rlib .lintr setup that checks if existing or incoming code uses base R condition handlers: https://github.com/r-lib/pkgdown/blob/819cede3fbbb2410912f4d49365177c9159b809f/.lintr.R.

We can add it after implementing this.

@sbfnk sbfnk removed this from EpiNow2 v2.0.0 Aug 7, 2024
@jamesmbaazam jamesmbaazam added this to the CRAN v1.6 release milestone Aug 7, 2024
@jamesmbaazam jamesmbaazam self-assigned this Aug 7, 2024
@jamesmbaazam
Copy link
Contributor

Working on this now. PR incoming.

@jamesmbaazam jamesmbaazam mentioned this issue Aug 29, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamesmbaazam jamesmbaazam

Labels
None yet
Projects
None yet
Milestone
CRAN v1.6 release
Development

Successfully merging a pull request may close this issue.

Replace base R message/warning/stop with {cli} epiforecasts/EpiNow2
2 participants
@sbfnk @jamesmbaazam