Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gamma_dist_def: scale is inverse scale? #498

Closed
seabbs opened this issue Nov 1, 2023 · 1 comment · Fixed by #504
Closed

gamma_dist_def: scale is inverse scale? #498

seabbs opened this issue Nov 1, 2023 · 1 comment · Fixed by #504
Labels
bug Something isn't working

Comments

@seabbs
Copy link
Contributor

seabbs commented Nov 1, 2023

It looks like in gamma_dist_def that scale is actually its inverse? This matches with the stan parameterization (which was passed in some models as alpha beta) but not with the R version.

https://github.com/epiforecasts/EpiNow2/blame/961c8c91063c6da381633ada387e2fba0337c101/R/dist.R#L340

THe renaming slipped through in the recent work on dist_spec but I am not clear if there was a deeper functionality issue and if that remains.

@seabbs seabbs added the bug Something isn't working label Nov 1, 2023
@sbfnk
Copy link
Contributor

sbfnk commented Nov 8, 2023

True but then it's passed (positionally) as inverse scale in

rgamma(n, params$shape, params$scale)

Both should probably be fixed as part of #382

@sbfnk sbfnk removed this from EpiNow2 v2.0.0 Feb 20, 2024
@sbfnk sbfnk moved this to In Progress in EpiNow2 v1.5.0 Feb 20, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in EpiNow2 v1.5.0 Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants