Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discretisation #411

Closed
sbfnk opened this issue Jul 3, 2023 · 4 comments · Fixed by #518
Closed

Discretisation #411

sbfnk opened this issue Jul 3, 2023 · 4 comments · Fixed by #518

Comments

@sbfnk
Copy link
Contributor

sbfnk commented Jul 3, 2023

The current discretisation of delay distributions integrates between integer boundaries [0, 1], [1, 2], ...

Recent work has shown that this leads to bias. A better option would be to discretise as [0, 1], [0, 2], [1, 3], ...

@seabbs
Copy link
Contributor

seabbs commented Jul 3, 2023

  • Relative to the underlying continuous distribution that may be used as a prior.

@sbfnk sbfnk mentioned this issue Jul 18, 2023
18 tasks
@jamesmbaazam
Copy link
Contributor

Can you link some of the recent work here?

@seabbs
Copy link
Contributor

seabbs commented Nov 6, 2023

https://github.com/epinowcast/epinowcast/blob/05b4f64be8ecb5f319c4cffb970698e91434c3a5/inst/stan/functions/discretised_logit_hazard.stan#L35 and see the package docs for the maths behind it.

The parts are all put together here: https://github.com/epinowcast/epinowcast/blob/05b4f64be8ecb5f319c4cffb970698e91434c3a5/inst/stan/functions/discretised_logit_hazard.stan#L127

The EpiNow2 version of this that has issues is:

vector discretised_pmf(real mu, real sigma, int n, int dist) {

@jamesmbaazam
Copy link
Contributor

Thanks, Sam. I'll take a look.

@jamesmbaazam jamesmbaazam moved this to Todo in EpiNow2 v2.0.0 Nov 10, 2023
@sbfnk sbfnk moved this from Todo to In Progress in EpiNow2 v2.0.0 Nov 17, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in EpiNow2 v2.0.0 Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants