Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distribution max is really the length #410

Closed
Tracked by #423
sbfnk opened this issue Jul 3, 2023 · 0 comments · Fixed by #468
Closed
Tracked by #423

Distribution max is really the length #410

sbfnk opened this issue Jul 3, 2023 · 0 comments · Fixed by #468

Comments

@sbfnk
Copy link
Contributor

sbfnk commented Jul 3, 2023

The max argument of probability distributions in dist_spec is not really the maximum, but the length of the PMF. Since its first index corresponds to 0, the maximum is actually max - 1.

There could be two solutions:

  1. changing the interpretation of max to correctly reflect the maximum
  2. changing the name of the argument to length

Since (1) is probably more intuitive to the user, I think it's the preferred option but would require more code changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
EpiNow2 v2.0.0
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clearer distinguish length and max epiforecasts/EpiNow2
1 participant
@sbfnk