-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add input validation #337
Comments
One thing perhaps to do is for every of the EpiNow2/R/estimate_infections.R Line 220 in dd484e2
estimate_infections that the arguments are of that class, avoiding instances where this is confused as e.g. in EpiNow2/tests/testthat/test-epinow.R Line 101 in dd484e2
|
@seabbs I would like to take a stab at this. Please assign me. |
Awesome - looking forward to seeing what you come up with. Make sure to target the |
There is no more |
Noted. |
I think many errors (both in my own usage and in some bug reports such as #267) seem to come from invalid input.
I understand that what constitutes a valid input is documented but I believe some extra hand-holding by failing early with clear error messages on invalid input would go a long way in helping users.
A main topic to discuss is probably what would be the best framework to do this input checking. Some options are presented in the 'Checking the inputs of your R functions' blog post.
The text was updated successfully, but these errors were encountered: