Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the driver firmware-version aware #31

Open
kmpeters opened this issue Jun 10, 2022 · 1 comment
Open

Make the driver firmware-version aware #31

kmpeters opened this issue Jun 10, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@kmpeters
Copy link
Contributor

Parameters like E2_AOFFS don't exist in firmware v2.70. Query the firmware version of a controller so that code that is only supported in newer versions of the firmware can be uncommented:

// TODO: re-add E2_AOFFS query after querying the firmware version
// E2_AOFFS doesn't exist in firmware v2.70
//status = pComm_->getDoubleArray((char *)absoluteEncoder2Offset_, "E2_AOFFS", 0, numAxes_-1, 0, 0);
//if (status != asynSuccess) return status;

@kmpeters kmpeters self-assigned this Jun 10, 2022
@kmpeters kmpeters added the enhancement New feature or request label May 9, 2023
@kmpeters
Copy link
Contributor Author

kmpeters commented May 9, 2023

Pull request #46 queries the version string, but doesn't do anything with it other than include it in asynReport output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant