RUSTSEC-2021-0145: Potential unaligned read

[github-actions]

Potential unaligned read

Details
Status	unsound
Package	atty
Version	0.2.14
URL	softprops/atty#50
Date	2021-07-04

On windows, atty dereferences a potentially unaligned pointer.

In practice however, the pointer won't be unaligned unless a custom global allocator is used.

In particular, the System allocator on windows uses HeapAlloc, which guarantees a large enough alignment.

atty is Unmaintained

A Pull Request with a fix has been provided over a year ago but the maintainer seems to be unreachable.

Last release of atty was almost 3 years ago.

Possible Alternative(s)

The below list has not been vetted in any way and may or may not contain alternatives;

• std::io::IsTerminal - Stable since Rust 1.70.0
• is-terminal - Standalone crate supporting Rust older than 1.70.0

See advisory page for additional details.

[Lut99]

Wait didn't we already look at this? Or was that at the policy-reasoner?

[DanielVoogsgerd]

Yes, we did look at this (#133). That issue was about it being unmaintained, but now it's also potentially vulnerable; great combination. 😅

To summarize the status. We have to merge #140, #165, and then merge the pull request Dependabot should provide us.

[Lut99]

OK, #140 and #165 are merged. Now waiting for that sweet Dependabot PR...