Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix overlapping transparent placeholder avatars in message reactions #667

Closed
Tracked by #509
saulmc opened this issue Sep 4, 2024 · 1 comment · Fixed by #1037
Closed
Tracked by #509

Fix overlapping transparent placeholder avatars in message reactions #667

saulmc opened this issue Sep 4, 2024 · 1 comment · Fixed by #1037
Assignees
@lourou
Labels
2.0.9 Release 2.0.9 bug Something isn't working

Comments

@saulmc
Copy link
Member

saulmc commented Sep 4, 2024

The Avatar component uses semi-transparent rgba background colors. This works fine against opaque backgrounds, but not with overlapping message reactions.
@saulmc saulmc added the bug Something isn't working label Sep 4, 2024
@saulmc saulmc mentioned this issue Sep 25, 2024
Closed
@saulmc
Copy link
Member Author

saulmc commented Oct 4, 2024 •
edited
Loading

This can be addressed as part of the broader reactions changeset proposed by @covrter .

https://xmtp-labs.slack.com/archives/C076F0L877T/p1728023498179779

@lourou lourou self-assigned this Oct 15, 2024
@lourou lourou mentioned this issue Oct 21, 2024
Merged
@lourou lourou added the 2.0.8 Release 2.0.8 label Oct 21, 2024
@lourou lourou closed this as completed Nov 4, 2024
@alexrisch alexrisch added 2.0.9 Release 2.0.9 and removed 2.0.8 Release 2.0.8 labels Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lourou lourou

Labels
2.0.9 Release 2.0.9 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rolled-up reactions ephemeraHQ/converse-app
3 participants
@saulmc @lourou @alexrisch