Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Search" placeholder text is hard to see on iOS light mode #589

Closed
Tracked by #509
saulmc opened this issue Aug 28, 2024 · 3 comments
Closed
Tracked by #509

"Search" placeholder text is hard to see on iOS light mode #589

saulmc opened this issue Aug 28, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@saulmc
Copy link
Member

saulmc commented Aug 28, 2024

It looks like the dark mode text style is being used in light mode.

@saulmc saulmc added the bug Something isn't working label Aug 28, 2024
@lourou
Copy link
Member

lourou commented Aug 29, 2024

Tried in battery-saving mode as shown in the screenshots, switching between light and dark mode multiple times, but unable to reproduce. Do you have a way to reproduce this @saulmc?

@alexrisch
Copy link
Collaborator

alexrisch commented Oct 2, 2024

I believe this was related to color scheme default usage

I believe what's going on is:

const colorScheme = useColorScheme
// colorScheme can sometimes be null

In certain places in the app we would default to dark mode, or light mode
ie:

if (colorScheme === "light")

or

if (colorScheme === "dark")

We need to pattern this to always be light mode (right now it should now always default to light mode, so only check if it's dark mode

It's a behavior of useColorScheme that can occasionally return null (it's known that it can be null) but seems inconsistent to actually make it happen

@alexrisch
Copy link
Collaborator

Duplicate of a different issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants
@saulmc @lourou @nmalzieu @alexrisch and others