-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Glowup and include context on group invite landing page and unfurl #581
Comments
@lourou would you be able to look into this Converse website request after the requests UI work is complete? I've added you to the repo I believe the group context info is all available. If not, we can descope from the designs rather than invest in piping it through. This should also extend to the opengraph metadata when one of these links is shared. Ideally, these links unfurl and include all of the above context information in an approximately equivalent design. |
@saulmc sure thing, will look into this! |
@saulmc do we want to generate on the fly and show a custom |
Hey @darickdang, I just finished implementing the group invite styling on mobile. Here's a preview on an iPhone 15 Pro screen. I also made sure it fits on iPhone SE and Mini. Do you see anything that needs to be changed? |
@saulmc desktop implementation is done, and so are the DM screen adaptations both on mobile and desktop! Some work left to do on the |
@saulmc I deployed on the preview subdomain for now, which hits the production backend, so this can be tested in real conditions. Feel free to test it on both mobile and desktop!
I noticed that sharing a link containing an ScreenshotsOpen Graph for GroupsExample |
This is awesome! Really thorough and looks great. @darickdang should anything be different in the og preview images from the website? |
onXmtp
andcanMessage
variables to display the buttons vs links to the App StoreThe text was updated successfully, but these errors were encountered: