Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glowup and include context on group invite landing page and unfurl #581

Closed
7 tasks done
Tracked by #570 ...
saulmc opened this issue Aug 27, 2024 · 9 comments
Closed
7 tasks done
Tracked by #570 ...

Glowup and include context on group invite landing page and unfurl #581

saulmc opened this issue Aug 27, 2024 · 9 comments
Assignees

Comments

@saulmc
Copy link
Member

saulmc commented Aug 27, 2024

  • Group Invite design styling on mobile
  • Troubleshoot the onXmtp and canMessage variables to display the buttons vs links to the App Store
  • Group Invite design styling on desktop
  • Adapt DM screen with the same styling on mobile
  • Adapt DM screen with the same styling on desktop
  • Update "Identity not found" screen, and "Groupe invite not found" screen
  • Design and implement the og:image/frame
@saulmc saulmc changed the title Glowup for group invite landing page Glowup for group invite landing page and unfurl Aug 28, 2024
@saulmc saulmc changed the title Glowup for group invite landing page and unfurl Glowup and include context on group invite landing page and unfurl Aug 28, 2024
@darickdang
Copy link
Collaborator

I'm not sure if I understand the logged in/logged out states correctly but here's what I got.

We should make this look similar to how they look in the app but pop the Converse logo with the word "Converse" on the web view.

Desktop Mobile - With App Mobile - No App

@saulmc
Copy link
Member Author

saulmc commented Sep 5, 2024

@lourou would you be able to look into this Converse website request after the requests UI work is complete? I've added you to the repo

I believe the group context info is all available. If not, we can descope from the designs rather than invest in piping it through.

This should also extend to the opengraph metadata when one of these links is shared. Ideally, these links unfurl and include all of the above context information in an approximately equivalent design.

@lourou
Copy link
Member

lourou commented Sep 5, 2024

@saulmc sure thing, will look into this!

@lourou
Copy link
Member

lourou commented Sep 5, 2024

@saulmc do we want to generate on the fly and show a custom og:image containing the group icon, converse logo and group description inside the image, so that users see this when shared?

@lourou lourou self-assigned this Sep 6, 2024
@lourou
Copy link
Member

lourou commented Sep 6, 2024

Hey @darickdang, I just finished implementing the group invite styling on mobile. Here's a preview on an iPhone 15 Pro screen. I also made sure it fits on iPhone SE and Mini. Do you see anything that needs to be changed?

@lourou
Copy link
Member

lourou commented Sep 10, 2024

@saulmc desktop implementation is done, and so are the DM screen adaptations both on mobile and desktop!

Some work left to do on the og:image

CleanShot 2024-09-10 at 17 43 33@2x

@lourou
Copy link
Member

lourou commented Sep 11, 2024

@saulmc I deployed on the preview subdomain for now, which hits the production backend, so this can be tested in real conditions. Feel free to test it on both mobile and desktop!

I noticed that sharing a link containing an og:image metatag in a conversation reloads the image every second indefinitely. I am opening a separate issue for this as it is not linked to the current one.

Screenshots

Open Graph for Groups

Example og:image render: https://www.opengraph.xyz/url/https%3A%2F%2Fpreview.converse.xyz%2Fgroup-invite%2FeB9j_d995cuq0-zmhn6tf

@saulmc
Copy link
Member Author

saulmc commented Sep 11, 2024

This is awesome! Really thorough and looks great.

@darickdang should anything be different in the og preview images from the website?
plug them in here: https://www.opengraph.xyz/

@lourou
Copy link
Member

lourou commented Sep 11, 2024

thanks @saulmc 🙌

re: the generic og:image loading loop issue inside the app, I created the issue here #716

@saulmc saulmc closed this as completed Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants