Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile creation: placeholder for profile image #572

Closed
Tracked by #570 ...
saulmc opened this issue Aug 26, 2024 · 2 comments · Fixed by #602
Closed
Tracked by #570 ...

Profile creation: placeholder for profile image #572

saulmc opened this issue Aug 26, 2024 · 2 comments · Fixed by #602
Assignees
Labels
design Needs design input/figmas

Comments

@saulmc
Copy link
Member

saulmc commented Aug 26, 2024

We are currently displaying what looks like a unicode fallback until the user enters username text. Should we just make this a question mark, or something else?

image

@saulmc saulmc added the design Needs design input/figmas label Aug 26, 2024
@darickdang
Copy link
Collaborator

If we're using SF Symbols to make this (I'm assuming this because I saw it in the symbols collection), we should either use the person.fill symbol or the photo symbol:

person.fill:
CleanShot 2024-08-27 at 23 23 56@2x

photo:
CleanShot 2024-08-27 at 23 22 22@2x

I think the "photo" option would work better since someone could upload a non-person photo for their pfp.

@lourou lourou assigned lourou and unassigned darickdang Aug 28, 2024
@lourou
Copy link
Member

lourou commented Aug 28, 2024

@darickdang I've used the photo icon as recommended and the corresponding icon in materials for Android. See screenshots below:

IMG_1211
IMG_1212

Screenshot_1724854539
Screenshot_1724854587

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Needs design input/figmas
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants