Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show both members of 2-member group in default profile photo #286

Closed
Tracked by #509
saulmc opened this issue Jul 16, 2024 · 4 comments
Closed
Tracked by #509

Show both members of 2-member group in default profile photo #286

saulmc opened this issue Jul 16, 2024 · 4 comments
Assignees

Comments

@saulmc
Copy link
Member

saulmc commented Jul 16, 2024

No description provided.

@saulmc saulmc added the design Needs design input/figmas label Jul 16, 2024
@saulmc saulmc changed the title What should the default group profile photo be when there are 2 members? Show both members of 2-member group in default profile photo Aug 26, 2024
@darickdang
Copy link
Collaborator

Not sure if we can do this proposal below but let me know if it does/doesn't work:

#286 - What should the default group profile photo be when there are 2 members_ #

Figma link: https://www.figma.com/design/p6mt4tEDltI4mypD3TIgUk/Converse-App?node-id=1699-12755&t=y4l53xPO9CbsUcKz-1

@alexrisch
Copy link
Collaborator

Dev notes:
Remove excludeSelf prop from components/GroupAvatar.tsx
Update shouldExclude logic to check for members length
Move function for memoizedAndSortedGroupMembers into a util file and add tests

@alexrisch
Copy link
Collaborator

@lourou This may already be done in the Feature V3 Chat, if you can help verify

@alexrisch alexrisch removed the design Needs design input/figmas label Nov 27, 2024
@lourou
Copy link
Member

lourou commented Dec 2, 2024

@alexrisch I checked, and it's done in the group chat creation screen, but not in the convos list or chat screen. Working in it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants