Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback when I try to message myself or add myself to group #177

Closed
Tracked by #509
saulmc opened this issue Jun 27, 2024 · 2 comments · Fixed by #1216
Closed
Tracked by #509

Feedback when I try to message myself or add myself to group #177

saulmc opened this issue Jun 27, 2024 · 2 comments · Fixed by #1216
Assignees
Labels

Comments

@saulmc
Copy link
Member

saulmc commented Jun 27, 2024

No description provided.

@saulmc saulmc added the design Needs design input/figmas label Jun 27, 2024
@darickdang
Copy link
Collaborator

When a user has multiple identities connected (or not connected), they may forget which account they're currently messaging from so their own account should show up in the search results but it should say "You" instead of "Chat"

#177 - Feedback when I try to message myself or add myself to group

Zeplin: https://app.zeplin.io/project/668c5499777e4ac004a04f97/screen/66cf5fb3b41d21c0b6ba74c3

@alexrisch alexrisch assigned lourou and unassigned darickdang Nov 7, 2024
@alexrisch alexrisch added Ready for Dev 2.0.8 Release 2.0.8 and removed design Needs design input/figmas labels Nov 7, 2024
@alexrisch
Copy link
Collaborator

This seems like a good time to move the components/Search/ProfileSearch.tsx & components/Search/ProfileSearchItem.tsx to our new design system/pattern as well as some clean up with screens/NewConversation/NewConversation.tsx

Dev Direction:

Move the referenced files into the new suggested folder pattern from the ADR

features/
├── search/
│   │   ├── components/
│   │   │   ├── SearchBar.tsx
│   │   │   ├── ProfileSearchItem.tsx
│   │   │   └── NoResult.tsx
│   │   ├── screens/
│   │   │   └── ProfileSearch.tsx
│   │   ├── navigation/
│   │   │   └── SearchNav.tsx
│   │   ├── hooks/
│   │   │   └── useSearchHooks.ts
│   │   ├── utils/
│   │   │   ├── search.ts
│   │   │   └── lens.ts
│   │   └── data/
│   │       └── store/
│   │           └── searchStore.ts

Also we should update the strings to be translated instead

Finally, when the address is the current account we should match the above design with a "You"

@alexrisch alexrisch added 2.0.9 Release 2.0.9 and removed 2.0.8 Release 2.0.8 labels Nov 14, 2024
@lourou lourou closed this as completed Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants