Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmarks do not compile #13

Open
cache-nez opened this issue Sep 12, 2022 · 2 comments
Open

Benchmarks do not compile #13

cache-nez opened this issue Sep 12, 2022 · 2 comments

Comments

@cache-nez
Copy link

The project has been upgraded to Scala 3 but the benchmarks are still in Scala 2.12 (in particular, parseback-core and parseback-cats dependencies are available in Scala 2.12 at the latest; it is possible to upgrade other dependencies to Scala 2.13 or Scala 3) which is incompatible.
@vkuncak
Copy link
Contributor

vkuncak commented Oct 16, 2022

PRs to do this upgrade at least partially are welcome.

@redelmann
Copy link
Member

The dependencies on parseback were for performance comparison purposes. Those benchmarks are not directly about Scallion and can thus be thrown out. The same might apply to other benchmarks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@redelmann @vkuncak @cache-nez