-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Splitting Source Files #70
Comments
Regarding 1. imo due to the small number of files even with the extension is perfectly reasonable. Bumping up to 6 files compared to 3 is no issue. And regarding 2. If all of the structs and helper functions would be in one file just for ImPlot I think it would be easier for people to contribute and work on the library. Once again, just my opinion. |
It's ok for me and i think will help extensions. |
This refactor has been introduced as of v0.5. See #48 for more info. |
I update without issues; an amalgamation script will be nice option for future. |
ImPlot has rapidly grown to almost 5000 LOC across all of its source files. While this is by no means large,
implot.cpp
is becoming a bit of a pain to navigate and maintain. I anticipate that this will become more challenging as the library grows. I'm considering splitting the source files in a manner similar to ImGui:implot.h
- no changeimplot_internal.h
- struct declarations and inline helper functions used internally bycpp
files.implot.cpp
- code related to creating Plot axes and maintaining their state (i.e.BeginPlot
/EndPlot
) and misc user APIimplot_items.cpp
- implementation and helpers related to plotting and rendering items (e.g.PlotLines
,PlotBars
etc)implot_demo.cpp
- no changeI'd like to get thoughts from our usual contributors and users. Specifically:
implot_internal.h
to extend/modify ImPlot if it were designed that way?The text was updated successfully, but these errors were encountered: