Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ChatKnowledge):pdf loader support table extraction #2147

Merged
merged 3 commits into from
Nov 21, 2024
Merged

feat(ChatKnowledge):pdf loader support table extraction #2147

merged 3 commits into from
Nov 21, 2024
+462 −45

Conversation

Aries-ckt
Copy link
Collaborator

Description

  • pdf loader refactor
  • added table extraction
    image

How Has This Been Tested?

  • make sure install pdfplumber
pip install pdfplumber
  • upload pdf with tables

Snapshots:

Include snapshots for easier review.

Checklist:

  • My code follows the style guidelines of this project
  • I have already rebased the commits and make the commit message conform to the project standard.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot added the enhancement New feature or request label Nov 21, 2024
@Aries-ckt Aries-ckt changed the title feat:pdf loader support table extraction feat(ChatKnowledge):pdf loader support table extraction Nov 21, 2024
@github-actions github-actions bot added the ChatKnowledge Module: ChatKnowledge label Nov 21, 2024
csunny
csunny approved these changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@csunny csunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

yhjun1026
yhjun1026 approved these changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@yhjun1026 yhjun1026 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@Aries-ckt Aries-ckt merged commit 43c86ca into eosphoros-ai:main Nov 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csunny csunny csunny approved these changes

@yhjun1026 yhjun1026 yhjun1026 approved these changes

Assignees
No one assigned
Labels
ChatKnowledge Module: ChatKnowledge enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Aries-ckt @yhjun1026 @csunny