-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Found and fix a mount issue with find #230
Found and fix a mount issue with find #230
Conversation
Thanks - could you squash these two commits? |
121ccdf
to
d8c021f
Compare
@ljharb Ok squashed |
@CurtisHumphrey thanks for finding this bug! I'm not sure we should be using the |
@lelandrichardson The instHasType helper in MountedTraversal is where the problem was. The same logic from ShallowTraversal's nodeHasType solved the problem and I was trying to keep it dry. I did not find anything in MountedTraversal that did the same check |
@CurtisHumphrey we should be adding code to the |
@lelandrichardson So you would prefer copy any paste? If so I can do that. Or I guess we could move the function into the utils file |
d8c021f
to
ed9398c
Compare
@lelandrichardson ok, I move the function into util, rebased and squashed |
@CurtisHumphrey it looks like you might have added some Sublime project files to your commit. |
ed9398c
to
2d69c0d
Compare
@aweary, remove them oops. |
Looks legit. Thanks! |
[mount] Fix find by component name
Found and fix a mount issue with find when using a named component e.g. find('Foo')
Added test case to highlight the issue
fixed someone else's lint issues too