stop adding null string key when there is a ref #1254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is there anything else needed before this is looked at? It'd be great to get it merged. Idk how many people it's affecting but I know my project can't upgrade to react 16 until it's done. |
ljharb
approved these changes
Oct 16, 2017
ljharb
requested review from
nfcampos,
lelandrichardson,
blainekasten,
aweary and
a team
|
cool thanks. i rebased off of master |
bdwain
force-pushed
the
fix-null-key
branch
2 times, most recently
from
3a5e564 to
bdccbd8
Compare
|
I rebased this. Does it need more approvals? |
|
Yes, I'd like a couple more reviewers to take a look first. |
|
Hi @ljharb is there anything i can do to get this reviewed and merged? I know it's blocking me from updating to react 16, and I'm sure it's blocking others as well. |
|
I'll give it a try locally. |
|
any luck with this? It's getting hard to keep it up to date because merge conflicts keep happening as master updates. |
|
Still working on it :-) I'll keep it up to date for you tho! |
ljharb
approved these changes
Nov 4, 2017
|
thanks! |
ljharb
added a commit
to ljharb/enzyme
that referenced
this pull request
Nov 5, 2017
- [fix] stop adding null string key when there is a ref (enzymejs#1254)
10 tasks
|
I believe #1511 was introduced in this PR |
jquense
pushed a commit
to jquense/enzyme
that referenced
this pull request
Feb 23, 2018
- [fix] stop adding null string key when there is a ref (enzymejs#1254)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1240 . Since react turns all valid (aka not undefined) keys into strings in react.createElement, it made sense to just remove falsey keys from nodes, so that when they were passed back through createElement, they didn't get turned into strings.
The tests I added fail with errors like
AssertionError: expected 'null' to equal nullwithout the changes I made.