Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate and eventually remove GetMetricByName in MetricsPlugin #889

Open
tomjzzhang opened this issue Aug 4, 2022 · 0 comments
Open

Deprecate and eventually remove GetMetricByName in MetricsPlugin #889

tomjzzhang opened this issue Aug 4, 2022 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed tech-debt

Comments

@tomjzzhang
Copy link
Contributor

With #885, GetMetricByName is now deprecated in favor of GetMetricByNameWithReportingPeriod.

We should give users of the plugin system time to migrate over and begin process to eventually remove the old call.
@tomjzzhang tomjzzhang added the enhancement New feature or request label Aug 4, 2022
@tomjzzhang tomjzzhang mentioned this issue Aug 4, 2022
Merged
@mum4k mum4k added tech-debt help wanted Extra attention is needed good first issue Good for newcomers and removed enhancement New feature or request labels Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed tech-debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomjzzhang @mum4k