From 37eca3cb42549ae795a6e558962de539b9f33901 Mon Sep 17 00:00:00 2001 From: Teju Nareddy Date: Tue, 20 Aug 2019 18:22:23 -0700 Subject: [PATCH 1/2] api config: add build rules for go protos Some BUILD files are missing build rules to generate go protos. `envoyproxy/go-control-plane` depends on these protos, so they should be exposed publicly. Added build rules to generate *.pb.go files. Signed-off-by: Teju Nareddy --- api/envoy/config/accesslog/v2/BUILD | 8 +++++++- api/envoy/config/filter/network/tcp_proxy/v2/BUILD | 12 +++++++++++- 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/api/envoy/config/accesslog/v2/BUILD b/api/envoy/config/accesslog/v2/BUILD index d6fd2d358929..e5f6a5e9957c 100644 --- a/api/envoy/config/accesslog/v2/BUILD +++ b/api/envoy/config/accesslog/v2/BUILD @@ -1,4 +1,4 @@ -load("@envoy_api//bazel:api_build_system.bzl", "api_proto_library_internal") +load("@envoy_api//bazel:api_build_system.bzl", "api_proto_library_internal", "api_go_proto_library") licenses(["notice"]) # Apache 2 @@ -14,3 +14,9 @@ api_proto_library_internal( name = "file", srcs = ["file.proto"], ) + +api_go_proto_library( + name = "als", + proto = ":als", + deps = ["//envoy/api/v2/core:grpc_service_go_proto"], +) diff --git a/api/envoy/config/filter/network/tcp_proxy/v2/BUILD b/api/envoy/config/filter/network/tcp_proxy/v2/BUILD index d77d910aceb2..efb7efcf3e53 100644 --- a/api/envoy/config/filter/network/tcp_proxy/v2/BUILD +++ b/api/envoy/config/filter/network/tcp_proxy/v2/BUILD @@ -1,4 +1,4 @@ -load("@envoy_api//bazel:api_build_system.bzl", "api_proto_library_internal") +load("@envoy_api//bazel:api_build_system.bzl", "api_proto_library_internal", "api_go_proto_library") licenses(["notice"]) # Apache 2 @@ -11,3 +11,13 @@ api_proto_library_internal( "//envoy/config/filter/accesslog/v2:accesslog", ], ) + +api_go_proto_library( + name = "tcp_proxy", + proto = ":tcp_proxy", + deps = [ + "//envoy/api/v2/core:address_go_proto", + "//envoy/api/v2/core:base_go_proto", + "//envoy/config/filter/accesslog/v2:accesslog_go_proto", + ], +) From f5a9488ae6694791f30523c14ef4930a9e178824 Mon Sep 17 00:00:00 2001 From: Teju Nareddy Date: Tue, 20 Aug 2019 21:57:39 -0700 Subject: [PATCH 2/2] Fix format Signed-off-by: Teju Nareddy --- api/envoy/config/accesslog/v2/BUILD | 2 +- api/envoy/config/filter/network/tcp_proxy/v2/BUILD | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/api/envoy/config/accesslog/v2/BUILD b/api/envoy/config/accesslog/v2/BUILD index e5f6a5e9957c..85ac228ccf13 100644 --- a/api/envoy/config/accesslog/v2/BUILD +++ b/api/envoy/config/accesslog/v2/BUILD @@ -1,4 +1,4 @@ -load("@envoy_api//bazel:api_build_system.bzl", "api_proto_library_internal", "api_go_proto_library") +load("@envoy_api//bazel:api_build_system.bzl", "api_go_proto_library", "api_proto_library_internal") licenses(["notice"]) # Apache 2 diff --git a/api/envoy/config/filter/network/tcp_proxy/v2/BUILD b/api/envoy/config/filter/network/tcp_proxy/v2/BUILD index efb7efcf3e53..e75ab7036b75 100644 --- a/api/envoy/config/filter/network/tcp_proxy/v2/BUILD +++ b/api/envoy/config/filter/network/tcp_proxy/v2/BUILD @@ -1,4 +1,4 @@ -load("@envoy_api//bazel:api_build_system.bzl", "api_proto_library_internal", "api_go_proto_library") +load("@envoy_api//bazel:api_build_system.bzl", "api_go_proto_library", "api_proto_library_internal") licenses(["notice"]) # Apache 2