ci: use small image and use remote_jdk #7786
Conversation
Signed-off-by: Lizan Zhou <[email protected]>
|
Note to reviewers: Don't review files under |
lizan
changed the title
| bazel query "@rbe_ubuntu_gcc_gen//..." | ||
| bazel query ${BAZEL_QUERY_OPTIONS} "@rbe_ubuntu_clang_gen//..." | ||
| bazel query ${BAZEL_QUERY_OPTIONS} "@rbe_ubuntu_clang_libcxx_gen//..." | ||
| bazel query ${BAZEL_QUERY_OPTIONS} "@rbe_ubuntu_gcc_gen//..." |
There was a problem hiding this comment.
why is this checked in? I thought that referencing that repo was enough?
There was a problem hiding this comment.
(the files this script generates I mean)
There was a problem hiding this comment.
I don't want to generate config everytime CI runs, so just generate them and check in the config.
There was a problem hiding this comment.
Signed-off-by: Lizan Zhou <[email protected]>
Signed-off-by: Lizan Zhou <[email protected]>
Signed-off-by: Lizan Zhou <[email protected]>
Signed-off-by: Lizan Zhou <[email protected]>
Signed-off-by: Lizan Zhou <[email protected]>
Signed-off-by: Lizan Zhou <[email protected]>
Signed-off-by: Lizan Zhou <[email protected]>
Signed-off-by: Lizan Zhou <[email protected]>
Description: Some tools missed from #7772 Risk Level: Testing: #7786 Docs Changes: Release Notes: Signed-off-by: Lizan Zhou <[email protected]>
Signed-off-by: Lizan Zhou <[email protected]>
| @@ -0,0 +1,149 @@ | |||
| # Copyright 2016 The Bazel Authors. All rights reserved. | |||
There was a problem hiding this comment.
Do you think you can move this to some other repository that we consume, to reduce the churn in the main Envoy repo? Just a suggestion, we can ship this PR as is.
There was a problem hiding this comment.
Yes it is totally possible to have whole bazel/toolchains/configs in a separate repo, or even just a generated tar in somewhere (like the build image). It just need more bash snafu to automate the generate process though.
I don't expect much more churn from here other than every bazel update (likely it will be just rename based on Bazel version) or adding new configuration (e.g. MSAN)
Signed-off-by: Lizan Zhou <[email protected]>
Signed-off-by: Lizan Zhou <[email protected]>
Description: Fixes post submit issue from #7786 Risk Level: Testing: Docs Changes: Release Notes: Signed-off-by: Lizan Zhou <[email protected]>
Signed-off-by: Lizan Zhou [email protected]
Description:
Use smaller image, bazel 0.28.1, regenerates config with gcc and libcxx
Risk Level: Low
Testing: CI
Docs Changes:
Release Notes: