Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libevent: fix duplicate symbols on macOS #10002

Merged
merged 3 commits into from
Feb 11, 2020

Conversation

rebello95
Copy link
Contributor

We're seeing duplicate symbols in Envoy Mobile coming from libevent: envoyproxy/envoy-mobile#677.

A binary search (checking out different shas of Envoy and rebuilding, then searching for duplicate symbols in the dump) shows that this upstream PR caused the duplicated symbols to appear: #9915, in particular this commit.

It appears that the libevent_core.a dependency is not needed for building, and was the source of the duplicate symbol. However, I'm not familiar with if/why this is necessary for win32, so maybe @wrowe can provide some context there.

Signed-off-by: Michael Rebello [email protected]

Signed-off-by: Michael Rebello <[email protected]>
@mattklein123
Copy link
Member

@wrowe can you own reviewing this? (Also can you accept the org invite I sent you so that I can assign this PR review to you?) Thank you!

Signed-off-by: Michael Rebello <[email protected]>
Signed-off-by: Michael Rebello <[email protected]>
@rebello95
Copy link
Contributor Author

@wrowe thanks for the context. I think excluding on macOS makes sense based on the details you shared. I pushed the requested changes to this PR and confirmed that the duplicate symbols are no longer present when building on macOS with this new configuration. Would you mind taking a look?

@rebello95 rebello95 changed the title libevent: fix duplicate symbols libevent: fix duplicate symbols on macOS Feb 11, 2020
Copy link
Member

@junr03 junr03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks for fixing @rebello95 and for the context @wrowe

@zuercher zuercher merged commit 74df8b3 into envoyproxy:master Feb 11, 2020
@rebello95 rebello95 deleted the libevent-dupe-symbols branch February 11, 2020 20:46
junr03 added a commit to envoyproxy/envoy-mobile that referenced this pull request Feb 11, 2020
This bump brings in two relevant fixes

    envoyproxy/envoy#10002 fixes #677
    envoyproxy/envoy#10003 fixes #671

Signed-off-by: Jose Nino <[email protected]>
jpsim pushed a commit that referenced this pull request Nov 28, 2022
This bump brings in two relevant fixes

    #10002 fixes #677
    #10003 fixes #671

Signed-off-by: Jose Nino <[email protected]>
Signed-off-by: JP Simard <[email protected]>
jpsim pushed a commit that referenced this pull request Nov 29, 2022
This bump brings in two relevant fixes

    #10002 fixes #677
    #10003 fixes #671

Signed-off-by: Jose Nino <[email protected]>
Signed-off-by: JP Simard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants