-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libevent: fix duplicate symbols on macOS #10002
Conversation
Signed-off-by: Michael Rebello <[email protected]>
@wrowe can you own reviewing this? (Also can you accept the org invite I sent you so that I can assign this PR review to you?) Thank you! |
Signed-off-by: Michael Rebello <[email protected]>
Signed-off-by: Michael Rebello <[email protected]>
@wrowe thanks for the context. I think excluding on macOS makes sense based on the details you shared. I pushed the requested changes to this PR and confirmed that the duplicate symbols are no longer present when building on macOS with this new configuration. Would you mind taking a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Thanks for fixing @rebello95 and for the context @wrowe
This bump brings in two relevant fixes envoyproxy/envoy#10002 fixes #677 envoyproxy/envoy#10003 fixes #671 Signed-off-by: Jose Nino <[email protected]>
This bump brings in two relevant fixes #10002 fixes #677 #10003 fixes #671 Signed-off-by: Jose Nino <[email protected]> Signed-off-by: JP Simard <[email protected]>
This bump brings in two relevant fixes #10002 fixes #677 #10003 fixes #671 Signed-off-by: Jose Nino <[email protected]> Signed-off-by: JP Simard <[email protected]>
We're seeing duplicate symbols in Envoy Mobile coming from
libevent
: envoyproxy/envoy-mobile#677.A binary search (checking out different shas of Envoy and rebuilding, then searching for duplicate symbols in the dump) shows that this upstream PR caused the duplicated symbols to appear: #9915, in particular this commit.
It appears that the
libevent_core.a
dependency is not needed for building, and was the source of the duplicate symbol. However, I'm not familiar with if/why this is necessary for win32, so maybe @wrowe can provide some context there.Signed-off-by: Michael Rebello [email protected]