Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support specifying tags at metric creation time #9730

Closed
snowp opened this issue Jan 18, 2020 · 2 comments
Closed

Support specifying tags at metric creation time #9730

snowp opened this issue Jan 18, 2020 · 2 comments
Assignees
Labels
area/stats enhancement Feature requests. Not bugs or questions.

Comments

@snowp
Copy link
Contributor

snowp commented Jan 18, 2020

Currently Envoy supports tags with a "tag extraction" indirection: all metric names are flat strings, but a set of regexes can be configured that extracts out tag values from this metric name. This makes sense when users want to add tags to existing metrics, but in cases where custom metrics are added through extensions, users might be know a priori what metric tags they want for a given metric.

Adding a constructor to the metric objects that allow passing a fixed set of tags would greatly simplify this case: instead of specifying a flat string and a set of tag regexes, the final name + tags can be specified directly.

@snowp snowp added enhancement Feature requests. Not bugs or questions. area/stats labels Jan 18, 2020
@snowp snowp self-assigned this Jan 18, 2020
@mattklein123
Copy link
Member

See also #9194 which this might be a dup of.

@snowp
Copy link
Contributor Author

snowp commented Jan 19, 2020

I think this issue is a bit narrower in scope but yeah I can close this out in favor of the other one. As a V1 I'll just make the tags settable as string pairs on the metric objects, and then down the line we add in tag optimizations around symbol usage as necessary.

@snowp snowp closed this as completed Jan 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/stats enhancement Feature requests. Not bugs or questions.
Projects
None yet
Development

No branches or pull requests

2 participants