Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConsistentHashing: provide use_hostname_for_hashing for eds based discovery. #33430

Closed
fcantournet opened this issue Apr 10, 2024 · 5 comments
Closed
Labels
area/eds enhancement Feature requests. Not bugs or questions. stale stalebot believes this issue/PR has not been touched recently

Comments

@fcantournet
Copy link

To achieve stable consistent hashing over endpoints in ringhash/maglev when using EDS we need something similar to use_hostname_for_hashing.

In e.g: kubernetes using statefulsets you have endpoints with a stable identity, but whose IP might change during rollouts.

If you use use_hostname_for_hashing and STRICT_DNS with the records for each endpoint you can achieve stable consistent hashing during rollouts, with minimal re-shuffling.

Can we make use_hostname_for_hashing work with EDS by using the hostname field of Endpoint ?

@fcantournet fcantournet added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Apr 10, 2024
@RyanTheOptimist RyanTheOptimist added area/eds and removed triage Issue requires triage labels Apr 10, 2024
@RyanTheOptimist
Copy link
Contributor

cc: @htuch @mattklein123

It looks like the eds cluster is currently unowned according to CODEOWNERS.md:
/*/extensions/clusters/eds/ @UNOWNED @UNOWNED
But perhaps that just needs to be updated?

@htuch
Copy link
Member

htuch commented Apr 11, 2024

@adisuissa

@adisuissa
Copy link
Contributor

I think that a pre-req to this is to get EDS working with non-ip hostnames, no?
This was requested quite a long time ago (#4290) but I don't think it gained enough momentum to be worked on.

Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label May 11, 2024
Copy link

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/eds enhancement Feature requests. Not bugs or questions. stale stalebot believes this issue/PR has not been touched recently
Projects
None yet
Development

No branches or pull requests

4 participants