MockOsSysCalls::setsockopt has unwarranted ASSERT

[efimki]

Title: MockOsSysCalls::setsockopt has unwarranted ASSERT

Description:
MockOsSysCalls::setsockopt has ASSERT(optlen == sizeof(int)); but setsockopt API allows socket options to have different length. This breaks our internal test that sets 16 byte socket option.

Repro steps:

The following test triggers an ASSERT in debug build:

TEST(MockOsSysCallsTest, TestSetSockopt) {
  Envoy::Api::MockOsSysCalls os_sys_calls;
  char big_sock_opt[11] = "bigsockopt";
  os_sys_calls.setsockopt(1, 2, 3, big_sock_opt, sizeof(big_sock_opt));
}

[efimki]

I'm not a setsockopt expert.
Maybe there should be an assert that optval != nullptr, and/or optlen != 0.

[RyanTheOptimist]

cc: @yanavlasov

[RyanTheOptimist]

I can't quite find an appropriate label for this. @yanavlasov, any suggestions?

[ggreenway]

@efimki feel free to create a PR to fix

[efimki]

Created #19126

[github-actions]

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

[efimki]

Fixed by #19126