Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

com_github_fmtlib_fmt has a newer release 8.0.1 #18052

Closed
ME-ON1 opened this issue Sep 9, 2021 · 13 comments
Closed

com_github_fmtlib_fmt has a newer release 8.0.1 #18052

ME-ON1 opened this issue Sep 9, 2021 · 13 comments

Comments

@ME-ON1
Copy link
Contributor

ME-ON1 commented Sep 9, 2021

WARNING com_github_fmtlib_fmt has a newer release than 7.0.3@<2020-08-07 13:39:57>:8.0.1@<2021-07-02 23:14:33>

@phlax
Copy link
Member

phlax commented Sep 9, 2021

@ME-ON1 does com_github_nodejs_http_parser have a newer release that we can use ?

other ci is flagging issues with it

@phlax
Copy link
Member

phlax commented Sep 9, 2021

/me wonders if you are [bot]

@phlax
Copy link
Member

phlax commented Sep 9, 2021

8/

@ME-ON1
Copy link
Contributor Author

ME-ON1 commented Sep 9, 2021

No i was working on this issue #16705 and was running script locally but it created issues.

@phlax
Copy link
Member

phlax commented Sep 9, 2021

cool, if you are looking to PR updates the one i posted needs looking at so i was watching you posting hoping it would appear 8/

i can look into it tho

@ME-ON1
Copy link
Contributor Author

ME-ON1 commented Sep 9, 2021

@ME-ON1 does com_github_nodejs_http_parser have a newer release that we can use ?

These are the logs coming from release_dates.py
Also have no knowledge about that. I'm new with code base here.

@phlax
Copy link
Member

phlax commented Sep 9, 2021

are you on slack ?

@ME-ON1
Copy link
Contributor Author

ME-ON1 commented Sep 9, 2021

Yes, with dogebinge name.

@moderation
Copy link
Contributor

@ME-ON1 does com_github_nodejs_http_parser have a newer release that we can use ?

other ci is flagging issues with it

The latest release for nodejs/http-parser is a documentation change saying the project is deprecated 😞

We had a couple of folks try to get the replacement llhttp over the line and it looks close but not quite there yet - #15814. @asraa has been leading the charge.

@phlax
Copy link
Member

phlax commented Sep 10, 2021

not an easyfix it seems. Also that PR keeps the legacy parser initially so the problem wouldnt go away straight away

@asraa
Copy link
Contributor

asraa commented Sep 10, 2021

yeah, it's been blocked for a while -- handed off to some other Googlers. maybe @KBaichoo knows the status? I'm not 100% sure who was taking it over...

@KBaichoo
Copy link
Contributor

We (me and @yanavlasov) haven't yet started digging into the llhttp yet, but are planning on working on it. There are a few open questions on how debuggable llhttp is given it's transpiled to C, and how patching it could work.

@phlax
Copy link
Member

phlax commented Oct 8, 2021

closing this as there is a newer ticket for it #18321

@phlax phlax closed this as completed Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants