Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log resolved admin port #16050

Closed
codefromthecrypt opened this issue Apr 18, 2021 · 3 comments · Fixed by #16197
Closed

log resolved admin port #16050

codefromthecrypt opened this issue Apr 18, 2021 · 3 comments · Fixed by #16197
Assignees
Labels
area/admin enhancement Feature requests. Not bugs or questions.

Comments

@codefromthecrypt
Copy link
Contributor

Title:
log resolved admin port

Description:
Right now, the admin port can be set to zero, avoiding port conflicts. It prints to console like so:

[external/envoy/source/server/server.cc:486] admin address: 127.0.0.1:0

It would be nice if this logged the actual listen port as that can be easier for "expect" like tools who parse console out vs determining the admin port file and parsing that.

@codefromthecrypt codefromthecrypt added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Apr 18, 2021
@htuch
Copy link
Member

htuch commented Apr 18, 2021

This makes sense, I'll leave this as an open issue, but you might also find https://www.envoyproxy.io/docs/envoy/latest/operations/cli#cmdoption-admin-address-path useful.

@htuch htuch added area/admin help wanted Needs help! and removed triage Issue requires triage labels Apr 18, 2021
@mk46
Copy link
Contributor

mk46 commented Apr 27, 2021

@htuch I would like to work on this.

@htuch htuch removed the help wanted Needs help! label Apr 28, 2021
@htuch
Copy link
Member

htuch commented Apr 28, 2021

@mk46 sure, assigned!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/admin enhancement Feature requests. Not bugs or questions.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants