Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Http2FloodMitigationTest flake #11290

Closed
mattklein123 opened this issue May 21, 2020 · 3 comments · Fixed by #11319
Closed

Http2FloodMitigationTest flake #11290

mattklein123 opened this issue May 21, 2020 · 3 comments · Fixed by #11319
Assignees
@alyssawilk
Labels
area/test flakes no stalebot Disables stalebot from closing an issue
Milestone
1.15.0

Comments

@mattklein123
Copy link
Member 

[ RUN      ] IpVersions/Http2FloodMitigationTest.Data/IPv6
-- Test timed out at 2020-05-21 19:00:33 UTC --
[       OK ] IpVersions/Http2FloodMitigationTest.Data/IPv6 (223822 ms)

[ RUN      ] IpVersions/Http2FloodMitigationTest.404/IPv4
-- Test timed out at 2020-05-21 19:58:27 UTC --
[       OK ] IpVersions/Http2FloodMitigationTest.404/IPv4 (245457 ms)

@alyssawilk probably from your recent speed up change?
This was referenced May 21, 2020
Merged
Merged
@mattklein123 mattklein123 added this to the 1.15.0 milestone May 21, 2020
@mattklein123 mattklein123 added the no stalebot Disables stalebot from closing an issue label May 21, 2020
@jmarantz
Copy link
Contributor

could we ifdef out this test on Mac until this is resolved, so CI is cleaner?

@alyssawilk
Copy link
Contributor

I'm just going to revert the changes in #11260 for the http2 tests.

@alyssawilk
Copy link
Contributor

(still think we should debug long term - requiring a 1s sleep to pass is crummy, but mitigate first, debug after)

@alyssawilk alyssawilk mentioned this issue May 26, 2020
Merged
@asraa asraa mentioned this issue May 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alyssawilk alyssawilk

Labels
area/test flakes no stalebot Disables stalebot from closing an issue
Projects
None yet
Milestone
1.15.0
Development

Successfully merging a pull request may close this issue.

test: restoring prior behavior for http2 flood tests alyssawilk/envoy
3 participants
@jmarantz @mattklein123 @alyssawilk