Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot restart support for user defined tags #10264

Open
snowp opened this issue Mar 5, 2020 · 0 comments
Open

Hot restart support for user defined tags #10264

snowp opened this issue Mar 5, 2020 · 0 comments
Labels

Comments

@snowp
Copy link
Contributor

snowp commented Mar 5, 2020

After #9743 we support specifying tags on metric creation, but there is no mechanism to populate the tags for metrics object after a hot restart. The full name (with the tag key-values included) would be transferred over, but without knowing how to split the name this would become the new stat name, and no tags would be moved over.

One possibility would be to insert a sentinel value in front of each key and value so that we can extract out the key/values during the stat merger:

stat.name.TAG_KEY.some.key.TAG_VALUE.some.value

would represent the stat stat.name with a single tag some.key = some.value

Another option would be to pass more than just a string during the hot restart, but iirc that would require changing the hot restart RPC proto, which might require bumping the hot restart version?

@jmarantz

@mattklein123 mattklein123 added the help wanted Needs help! label Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants