From 20dbc5b6da6fb8b472fa51895d8311310541312d Mon Sep 17 00:00:00 2001 From: Matt Klein Date: Thu, 18 Apr 2019 10:33:56 -0700 Subject: [PATCH] ci: setup basic check format (#3) We can extend this for other languages, etc. in the future. Signed-off-by: Matt Klein Signed-off-by: JP Simard --- mobile/.circleci/config.yml | 8 ++++++++ mobile/OWNERS.md | 2 ++ mobile/envoy | 2 +- mobile/tools/check_format.sh | 8 ++++++++ 4 files changed, 19 insertions(+), 1 deletion(-) create mode 100755 mobile/tools/check_format.sh diff --git a/mobile/.circleci/config.yml b/mobile/.circleci/config.yml index c3bf80f68742..d1c4d80a8b2f 100644 --- a/mobile/.circleci/config.yml +++ b/mobile/.circleci/config.yml @@ -22,6 +22,13 @@ jobs: - run: docs/publish.sh - store_artifacts: path: generated/docs + format: + executor: ubuntu-build + # TODO(mattklein123): resource_class: small + steps: + - checkout + - run: git submodule update --init + - run: tools/check_format.sh workflows: version: 2 @@ -31,3 +38,4 @@ workflows: filters: tags: only: /^v.*/ + - format diff --git a/mobile/OWNERS.md b/mobile/OWNERS.md index ad90b72e4680..28a3cf66b72b 100644 --- a/mobile/OWNERS.md +++ b/mobile/OWNERS.md @@ -1,3 +1,5 @@ +# Envoy Mobile owners + * See [CONTRIBUTING.md](CONTRIBUTING.md) for general contribution guidelines. This page lists all active maintainers and their areas of expertise. This can be used for diff --git a/mobile/envoy b/mobile/envoy index a87a09d1b469..0e109cb3ba3b 160000 --- a/mobile/envoy +++ b/mobile/envoy @@ -1 +1 @@ -Subproject commit a87a09d1b469942c206d07f4654983db26f1ecc2 +Subproject commit 0e109cb3ba3be0823bdb696eacb02a827989efa1 diff --git a/mobile/tools/check_format.sh b/mobile/tools/check_format.sh new file mode 100755 index 000000000000..cc6b2276eb1c --- /dev/null +++ b/mobile/tools/check_format.sh @@ -0,0 +1,8 @@ +#!/usr/bin/env bash + +set -e + +export BUILDIFIER_BIN="/usr/local/bin/buildifier" + +envoy/tools/check_format.py --add-excluded-prefixes=./envoy/ check +envoy/tools/format_python_tools.sh check