You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Request motivated by the fact that we simply don't have need for it.
There are a few simple and one complex change involved:
Make HazelCastConfig require a profile for activation. Very straightforward, just add @Profile("hazelcast") or somesuch.
Instruct users to add spring.autoconfigure.exclude=org.springframework.boot.autoconfigure.hazelcast.HazelcastAutoConfiguration into application configuration if they wish to disable the feature.
Instead of autowiring an instance of HazelcastInstance in application components abstract the needed functionality into an interface and convert the Hazelcast integration into a helper module structure, possibly under rutebanken-helpers following the modularization logic there.
It's worth noting that there already is rutebanken-helper/hazelcast4-helper and the code in tiamat seems to be a direct match with that one. Looking at the version history things have diverged, and the helper in fact has some relevant, useful changes in it already.
The text was updated successfully, but these errors were encountered:
Request motivated by the fact that we simply don't have need for it.
There are a few simple and one complex change involved:
HazelCastConfig
require a profile for activation. Very straightforward, just add@Profile("hazelcast")
or somesuch.spring.autoconfigure.exclude=org.springframework.boot.autoconfigure.hazelcast.HazelcastAutoConfiguration
into application configuration if they wish to disable the feature.HazelcastInstance
in application components abstract the needed functionality into an interface and convert the Hazelcast integration into a helper module structure, possibly underrutebanken-helpers
following the modularization logic there.It's worth noting that there already is
rutebanken-helper/hazelcast4-helper
and the code in tiamat seems to be a direct match with that one. Looking at the version history things have diverged, and the helper in fact has some relevant, useful changes in it already.The text was updated successfully, but these errors were encountered: