Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow disabling of Hazelcast support #197

Open
esuomi opened this issue Feb 21, 2025 · 0 comments
Open

allow disabling of Hazelcast support #197

esuomi opened this issue Feb 21, 2025 · 0 comments
Assignees

Comments

@esuomi
Copy link
Collaborator

esuomi commented Feb 21, 2025

Request motivated by the fact that we simply don't have need for it.

There are a few simple and one complex change involved:

  1. Make HazelCastConfig require a profile for activation. Very straightforward, just add @Profile("hazelcast") or somesuch.
  2. Instruct users to add spring.autoconfigure.exclude=org.springframework.boot.autoconfigure.hazelcast.HazelcastAutoConfiguration into application configuration if they wish to disable the feature.
  3. Instead of autowiring an instance of HazelcastInstance in application components abstract the needed functionality into an interface and convert the Hazelcast integration into a helper module structure, possibly under rutebanken-helpers following the modularization logic there.

It's worth noting that there already is rutebanken-helper/hazelcast4-helper and the code in tiamat seems to be a direct match with that one. Looking at the version history things have diverged, and the helper in fact has some relevant, useful changes in it already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants