Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MismatchedBroadcastsEvidence::verify should have its logic depend on error #52

Closed
fjarri opened this issue Oct 29, 2024 · 0 comments · Fixed by #54
Closed

MismatchedBroadcastsEvidence::verify should have its logic depend on error #52

fjarri opened this issue Oct 29, 2024 · 0 comments · Fixed by #54
Assignees
@fjarri
Labels
bug Something isn't working
Milestone
v0.1.0

Comments

@fjarri
Copy link
Member

fjarri commented Oct 29, 2024

Since we have different types of errors now, the logic in verify should account for that; currently it behaves as if error == MismatchedBroadcastsError::DifferentPayloads.
@fjarri fjarri added the bug Something isn't working label Oct 29, 2024
@fjarri fjarri added this to the v0.1.0 milestone Oct 29, 2024
@fjarri fjarri mentioned this issue Oct 30, 2024
Merged
@fjarri fjarri self-assigned this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fjarri fjarri

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging a pull request may close this issue.

Various evidence-related fixes fjarri/manul
1 participant
@fjarri