Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An invalid message evidence generated during an echo round cannot be verified #49

Closed
fjarri opened this issue Oct 28, 2024 · 0 comments · Fixed by #54
Closed

An invalid message evidence generated during an echo round cannot be verified #49

fjarri opened this issue Oct 28, 2024 · 0 comments · Fixed by #54
Assignees
Labels
bug Something isn't working
Milestone

Comments

@fjarri
Copy link
Member

fjarri commented Oct 28, 2024

InvalidDirectMessageEvidence etc call Protocol::verify_direct_message_is_invalid() to verify that the attached message is invalid, which will naturally fail for an echo round message, since the round ID is unknown to the protocol. There needs to be special processing if the message's round_id indicates it's an echo.

@fjarri fjarri added the bug Something isn't working label Oct 28, 2024
@fjarri fjarri added this to the v0.1.0 milestone Oct 28, 2024
@fjarri fjarri self-assigned this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant