Reshare in a spawned task and fix propagation pallet rotate keyshares endpoint lookup key #1185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HCastano
approved these changes
Nov 26, 2024
| @@ -369,7 +369,7 @@ pub fn new_full_base( | |||
| ); | |||
| offchain_db.local_storage_set( | |||
| sp_core::offchain::StorageKind::PERSISTENT, | |||
| b"rotate_keyshares", | |||
| b"rotate_network_key", | |||
There was a problem hiding this comment.
Ah, is this the key you're saying is incorrect?
So even with an extended timeout this wasn't going to work then?
There was a problem hiding this comment.
This was incorrect. But im not sure if it actually makes a difference in production, since if the lookup fails it defaults to 127.0.0.1:3001/rotate_network_key, which is usually what we want. I think its only in our test setup that we need to set a custom endpoint.
HCastano
changed the title
|
Maybe worth adding a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When fixing the reshare test in #1162 i found two problems which mean the resharing will not work in production.
I have fixed these in #1162 - but since that PR makes quite some changes to our test setup, and still needs some cleaning up, i wanted to put the fixes in a separate PR, so its clear what they are, and so it could be used for a fix for our current testnet (resharing will not work without these fixes).
If we want to fix things with a runtime upgrade and not need to update the TSS code, we could bump up the timeout instead of spawning a task for the reshare. But i think long term it is better to use a separate task, because amount of time the reshare takes depends on many factors.