Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDE died while editing a node #6672

Closed
2 tasks
sylwiabr opened this issue May 12, 2023 · 12 comments
Closed
2 tasks

IDE died while editing a node #6672

sylwiabr opened this issue May 12, 2023 · 12 comments
Assignees
Labels
--bug Type: bug --regression Important: regression -language-server p-highest Should be completed ASAP s-info-needed Status: more information needed from submitter

Comments

@sylwiabr
Copy link
Member

Discord username

No response

What type of issue is this?

Intermittent – Occurring irregularly

Is this issue blocking you from using Enso?

  • Yes, I can't use Enso because of this issue.

Is this a regression?

  • Yes, previous version of Enso did not have this issue.

What issue are you facing?

It happened few times during last two days: IDE died without any message to the user while working normally (editing the node). The error in the console was: Peer has replied with an error: File not found . Full session had just around 4 min so attaching the link to the video: https://drive.google.com/file/d/1ajtJTaEkFsGMe0bg8YnO5SAt9aGGtf7x/view?usp=share_link

Expected behaviour

IDE should never die.

How we can reproduce it?

No response

Screenshots or screencasts

No response

Enso Version

develop 12.05

Browser or standalone distribution

Standalone distribution

Browser Version or standalone distribution

standalone

Operating System

Windows

Operating System Version

No response

Hardware you are using

No response

@sylwiabr sylwiabr added --bug Type: bug triage labels May 12, 2023
@sylwiabr sylwiabr added the --regression Important: regression label May 12, 2023
@sylwiabr
Copy link
Member Author

@farmaazon @4e6 have a look here. IDE should never die - it was a short session, nothing controversial. During last days we encountered exactly this error 2-3 times and we had to restart IDE multiple time because it was unusable. Also we lost our work few times due to this and other problems (like problems with synchronization between IDE and engine).

@sylwiabr sylwiabr added the p-highest Should be completed ASAP label May 12, 2023
@Akirathan Akirathan added -language-server s-info-needed Status: more information needed from submitter labels May 15, 2023
@jdunkerley
Copy link
Member

jdunkerley commented May 16, 2023

I think making the engine sluggish by running in trace mode will help reproduce.

Project: https://drive.google.com/file/d/11jOQvmkEhplUfPDlvGPnESkiV5EXnmoO/view?usp=share_link

@jdunkerley jdunkerley moved this from ❓New to 📤 Backlog in Issues Board May 16, 2023
@jdunkerley jdunkerley assigned JaroslavTulach and unassigned hubertp May 16, 2023
@jdunkerley jdunkerley moved this from 📤 Backlog to ❓New in Issues Board May 16, 2023
@jdunkerley jdunkerley moved this from ❓New to 📤 Backlog in Issues Board May 16, 2023
@JaroslavTulach
Copy link
Member

The video shows following log at 3:42:

obrazek

At 22:06 the HeartbeatSession] stopped. At 22:15 the HeartbeatSession] started - what does that mean? Is the IDE trying to reconnect? Btw. at 22:21 the heartbeat stops again.

Is there any other explanation of the heartbeat stopping/starting than an attempt to reconnect? The IDE logs (shown at 4:02 of the video) do not contain any message about reconnecting, however.

@farmaazon
Copy link
Contributor

The Heartbeat is an internal Engine thing, IDE do not use it.

@hubertp
Copy link
Collaborator

hubertp commented May 17, 2023

@JaroslavTulach Heartbeat session is a shortlived action that starts and dies regularly. sending/receiving the regular ping/pong. This is as expected.

@JaroslavTulach
Copy link
Member

sending/receiving the regular ping/pong. This is as expected

That means the connection between the IDE and engine is OK, right? Alas, if it is OK, then I have no other idea what can be wrong...

@sylwiabr
Copy link
Member Author

@JaroslavTulach the issues we are observing recently like this one, #6727 or #6634 are not caused by IDE/LS loosing the connection. Probably this is why IDE is not reporting issues. They all have common part: evaluation of newly added nodes is not happening but the connection is there.

@JaroslavTulach
Copy link
Member

JaroslavTulach commented May 17, 2023

We need to find out what is happening in the Enso engine/LS process - let's download VisualVM and then:

  • open the org.enso.runner.Main process
  • take a thread dump (Threads tab/Thread Dump button / copy and paste)
  • sample what the application does (Sampler tab / CPU button / Snapshot / save into a file)
  • take a heap dump (right click on the process node)

obrazek

With such information we should have a better insight of what is happening in the engine/LS process:

  • thread dump would show us if the engine is blocked somewhere
  • profiling sample allows us to record few seconds and deduce what the engine is doing at that time
  • heap dump allows us to inspect internal objects like actors, etc.

@JaroslavTulach
Copy link
Member

Alas, we have just done both (thread dump and profiling) with James and the LS/engine process does nothing! The next step is to find out whether there are some messages sent to the process at all.

@enso-bot enso-bot bot mentioned this issue May 18, 2023
2 tasks
@Akirathan Akirathan removed the triage label May 18, 2023
@hubertp
Copy link
Collaborator

hubertp commented May 18, 2023

Sounds vaguely similar to #6763

@JaroslavTulach
Copy link
Member

I guess we should invest into an infrastructure that would allow us to capture/record the state of the engine easily:

@jdunkerley
Copy link
Member

Closing as we believe is related to #6763.

@jdunkerley jdunkerley closed this as not planned Won't fix, can't repro, duplicate, stale May 23, 2023
@github-project-automation github-project-automation bot moved this from 📤 Backlog to 🟢 Accepted in Issues Board May 23, 2023
@jdunkerley jdunkerley added this to the Design Partners milestone May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--bug Type: bug --regression Important: regression -language-server p-highest Should be completed ASAP s-info-needed Status: more information needed from submitter
Projects
Archived in project
Development

No branches or pull requests

6 participants