Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component Browser closes when opened by dragging the output too quickly #6579

Closed
2 tasks
4e6 opened this issue May 5, 2023 · 7 comments
Closed
2 tasks

Component Browser closes when opened by dragging the output too quickly #6579

4e6 opened this issue May 5, 2023 · 7 comments
Assignees
Labels
--bug Type: bug d-intermediate Difficulty: some prior knowledge required p-high Should be completed in the next sprint s-no-repro Status: can't reproduce the issue

Comments

@4e6
Copy link
Contributor

4e6 commented May 5, 2023

Discord username

No response

What type of issue is this?

Permanent – Occurring repeatably

Is this issue blocking you from using Enso?

  • Yes, I can't use Enso because of this issue.

Is this a regression?

  • Yes, previous version of Enso did not have this issue.

What issue are you facing?

The component browser opens and closes instantly when you pull the output node and release it very quickly. When you wait a second after pulling the output (the last attempt on the video), it works properly.

Expected behaviour

The component browser remains open.

How we can reproduce it?

No response

Screenshots or screencasts

issue-1.mp4

Enso Version

a842130

Browser or standalone distribution

Chromium

Browser Version or standalone distribution

113.0.5672.63

Operating System

Linux

Operating System Version

No response

Hardware you are using

No response

@4e6 4e6 added --bug Type: bug triage labels May 5, 2023
@github-project-automation github-project-automation bot moved this to ❓New in Issues Board May 5, 2023
@sylwiabr sylwiabr added the p-high Should be completed in the next sprint label May 5, 2023
@vitvakatu
Copy link
Contributor

I can't reproduce the closing thing, but it indeed opens when you start to drag the edge and quickly release the mouse button.

@vitvakatu vitvakatu added the d-intermediate Difficulty: some prior knowledge required label May 7, 2023
@wdanilo
Copy link
Member

wdanilo commented May 8, 2023

@vitvakatu it should open when you press - drag - release. This is intentional.

@farmaazon
Copy link
Contributor

@xvcgreg as Ilya hasn't reproduced it, could you put a screencast with console logs?

@farmaazon farmaazon moved this from ❓New to 📤 Backlog in Issues Board May 10, 2023
@xvcgreg
Copy link

xvcgreg commented May 10, 2023

@farmaazon sure, here you go:

2305101151_shareX.mp4

also at the end please observe that CB is opened and I can still drag the connection

@xvcgreg
Copy link

xvcgreg commented May 12, 2023

tested on https://github.com/enso-org/enso/actions/runs/4947660213?pr=6648 @farmaazon

2305121129 CLI log.txt
2305121129_shareX localhost-1683883871663.log

2305121129_shareX.mp4
GitHub
Hybrid visual and textual functional programming. Contribute to enso-org/enso development by creating an account on GitHub.

@farmaazon
Copy link
Contributor

Ok, there was some misunderstanding here between me and @xvcgreg, so let's clarify some things:

  1. Dragging out an edge and dropping it opens CB by design, as Wojciech wrote above.
  2. Dragging out an edge and dropping it with two clicks too quickly is interpreted as double click, so we try to leave the current node. Perhaps it should be blocked when dragging and edge
  3. I still cannot reproduce Component Browser being closed immediately after opening.

@4e6
Copy link
Contributor Author

4e6 commented May 12, 2023

@farmaazon I cannot reproduce it anymore on the current develop

@farmaazon farmaazon added the s-no-repro Status: can't reproduce the issue label May 15, 2023
@farmaazon farmaazon closed this as not planned Won't fix, can't repro, duplicate, stale May 15, 2023
@github-project-automation github-project-automation bot moved this from 📤 Backlog to 🟢 Accepted in Issues Board May 15, 2023
@sylwiabr sylwiabr removed this from Issues Board May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--bug Type: bug d-intermediate Difficulty: some prior knowledge required p-high Should be completed in the next sprint s-no-repro Status: can't reproduce the issue
Projects
None yet
Development

No branches or pull requests

6 participants