Fix treatment of WithWarnings in builtin method annotation processor

[Akirathan]

org.enso.interpreter.dsl.MethodProcessor generates code for every builtin method in such a way that it removes all the warnings from all the arguments, except for self, and then reattaches these gathered warnings to the result. It does that by checking if (arg instanceof WithWarnings) which is incorrect, it should be replaced by WarningsLibrary.hasWarnings(arg). Moreover, the lack of warnings removal from the self argument is suspicious, since you have to take care of the warnings in the builtin method manually.

This might cause problems especially for vectors, for which, if one of the elements has a warning attached, it is propagated to the whole vector and sometimes duplicated across other elements.

Tasks

Preview Give feedback

1. Replace instanceof WithWarnings checks by WarningsLibrary.hasWarnings(arg).
2. Investigate warning removal from self argument.

Related:

• Decorate values with arbitrary warnings #3248
• Vector should preserve warnings #3938

[hubertp]

Regarding warnings on self. I think that part will have to stay in order to be able to do dispatch on Warning correctly. This was for example needed for #6176.

[Akirathan]

Closing this as not an issue:

Stripping of warnings from the self argument is controlled by AcceptsWarning annotation.

Checking for warnings via instanceof is just fine. Passing messages via WarningsLibrary has unnecessary overhead.