Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polyglot values are not recognized as their Enso equivalents by the IDE #5026

Closed
wdanilo opened this issue Feb 5, 2023 · 0 comments · Fixed by #4111
Closed

Polyglot values are not recognized as their Enso equivalents by the IDE #5026

wdanilo opened this issue Feb 5, 2023 · 0 comments · Fixed by #4111
Assignees
Labels
--bug Type: bug -compiler -language-server p-high Should be completed in the next sprint
Milestone

Comments

@wdanilo
Copy link
Member

wdanilo commented Feb 5, 2023

This task is automatically imported from the old Task Issue Board and it was originally created by James Dunkerley.
Original issue is here.


If you have a Java Date that comes to the IDE from the polyglot world it's type is not recognized and so you get no help from the CB etc.

The engine side works fine so the functions do work but you need to know them rather than it guiding you.

This is true for a simple

polyglot java import java.time.LocalDate

main = 
    operator1 = LocalDate.now

but it occurred from parsing a table with dates in it.

The same is true if I embed a simple JS function and call it:

foreign js hello = """
    return "Hello World!"

The text returned's type is not known.
If the polyglot returns a number the type is known as normal.

Comments:

(James Dunkerley - Jan 27, 2023)


In a debugging session, I compared what is sent over the websocket between IDE and LS when editing a node to `Date.now` or `LocalDate.now`. The difference seems to be in "executionContext/expressionUpdates" message sent from LS which has `type: null` in its `updates` field for `LocalDate.now`. Apart from that, I was not yet able to pinpoint the exact point where the type of a node is resolved. (Pavel Marek - Jan 31, 2023)
This is a log, with trace enabled, when I tried to add nodes to an empty project (with just imports) with `LocalDate.now`, `Date.now` and `My_Type.Value 42`. (Pavel Marek - Feb 1, 2023)
Removed regression tag - it's been like that since inception. (Hubert Plociniczak - Feb 3, 2023)
**Hubert Plociniczak** reports a new **STANDUP** for yesterday (2023-02-02):

Progress: Investigating suboptimal JGit performance at startup which was leading to occasional timeouts. Improvement is ready in a PR but will be eventually replaced by git itself due to unsatisfactory performance. It should be finished by 2023-02-03.

Next Day: Next day I will be working on the #184336928 task. Go back to fixing reporting types for polyglot values, based on Jaroslav's feedback. (Enso Bot - Feb 3, 2023)


**Hubert Plociniczak** reports a new **STANDUP** for the last Wednesday (2023-02-01):

Progress: Investigating why the typo of polyglot values isn't shown for polyglot values. Draft PR ready for some discussion. Ongoing stability issues investigations. It should be finished by 2023-02-03.

Next Day: Next day I will be working on the #184359934 task. Needs discussion with Jaroslav regarding the approach (currently assertions fail), investigating timeouts happening at startup (Enso Bot - Feb 3, 2023)


@wdanilo wdanilo moved this to ✅ Done in Issues Board Feb 6, 2023
@wdanilo wdanilo moved this from ✅ Done to 👀 In review in Issues Board Feb 6, 2023
@wdanilo wdanilo moved this from 👀 In review to 🔖 Ready in Issues Board Feb 6, 2023
@wdanilo wdanilo added this to the Beta Release milestone Feb 6, 2023
@jdunkerley jdunkerley linked a pull request Feb 7, 2023 that will close this issue
4 tasks
@hubertp hubertp added p-high Should be completed in the next sprint and removed p-low Low priority labels Feb 8, 2023
@mergify mergify bot closed this as completed in #4111 Feb 9, 2023
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--bug Type: bug -compiler -language-server p-high Should be completed in the next sprint
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants