Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add white space rendering to Text fields in Table viz #10247

Closed
jdunkerley opened this issue Jun 11, 2024 · 9 comments · Fixed by #10563
Closed

Add white space rendering to Text fields in Table viz #10247

jdunkerley opened this issue Jun 11, 2024 · 9 comments · Fixed by #10563
Assignees
Labels
-libs Libraries: New libraries to be implemented -viz

Comments

@jdunkerley
Copy link
Member

jdunkerley commented Jun 11, 2024

Want to use a fixed width font.
It should not do glyphs (i.e. render => as two character no a merged glyph)

We should render whitespace in the normal way.

  • Space => . (centered vertical)
  • Tab => (padded out to 4 spaces)
  • Return =>
  • New Line => (and a new line in the cell).
  • Otherwise => (and a tooltip showing the uni-code name (hardcoded list))

They should be in a light grey.

Button to switch on the rendering on/off/special (default) in the toolbar.

Special mode, renders

  • leading/trailing whitespace is rendered.
  • multiple spaces and non-space chars rendered.
  • \r, \r\n, \n should be rendered and add a new line.

Hello World
Hello World => Hello..World

Copy from the table should not include the whitespace rendering.

@jdunkerley jdunkerley converted this from a draft issue Jun 11, 2024
@jdunkerley jdunkerley added -libs Libraries: New libraries to be implemented -viz labels Jun 11, 2024
@jdunkerley jdunkerley added this to the 2024-08 Release milestone Jun 19, 2024
@jdunkerley jdunkerley changed the title Add white space rendering to Text fields Add white space rendering to Text fields in Table viz Jul 2, 2024
@marthasharkey marthasharkey moved this from 📤 Backlog to 🔧 Implementation in Issues Board Jul 3, 2024
@enso-bot
Copy link

enso-bot bot commented Jul 3, 2024

Martha King reports a new STANDUP for today (2024-07-03):

Progress: merged connections PR, created formatText function working for space, new line need to create better data to check for other examples. font is monaspace It should be finished by 2024-07-12.

@enso-bot
Copy link

enso-bot bot commented Jul 4, 2024

Martha King reports a new STANDUP for today (2024-07-04):

Progress: merged Decimal deserialisation in table viz. Worked on adding tool bar button to select which setting for the text formatter. It should be finished by 2024-07-12.

@enso-bot
Copy link

enso-bot bot commented Jul 8, 2024

Martha King reports a new STANDUP for today (2024-07-08):

Progress: worked on bug for column sort in table vizualisation and continued looking into new toggle in toolbar It should be finished by 2024-07-12.

@enso-bot
Copy link

enso-bot bot commented Jul 11, 2024

Martha King reports a new STANDUP for today (2024-07-11):

Progress: made basic toggle with text buttons that changes the format choices, some tweaks still needed to the different settings and to make the toggle look better It should be finished by 2024-07-12.

@enso-bot
Copy link

enso-bot bot commented Jul 12, 2024

Martha King reports a new STANDUP for today (2024-07-12):

Progress: working on adding svg icon in toggle, and edgecases of text format It should be finished by 2024-07-12.

@enso-bot
Copy link

enso-bot bot commented Jul 16, 2024

Martha King reports a new STANDUP for yesterday (2024-07-15):

Progress: added svgs and tidied up buttons, tested with various different preppin data challenges to see how it renders It should be finished by 2024-07-19.

@enso-bot
Copy link

enso-bot bot commented Jul 16, 2024

Martha King reports a new STANDUP for today (2024-07-16):

Progress: raised PR and tested with a few more preppin data and started looking at listening to sorting and filtering It should be finished by 2024-07-19.

@enso-bot
Copy link

enso-bot bot commented Jul 17, 2024

Martha King reports a new STANDUP for today (2024-07-17):

Progress: worked on PR comments, moving from radio buttons to drop down, drop down partially working but still work on style to go It should be finished by 2024-07-19.

@enso-bot
Copy link

enso-bot bot commented Jul 22, 2024

Martha King reports a new STANDUP for today (2024-07-22):

Progress: worked on PR comments using menu buttons rather than svg buttons, PR should be ready to go when pipeline passes It should be finished by 2024-07-23.

@mergify mergify bot closed this as completed in #10563 Jul 23, 2024
@mergify mergify bot closed this as completed in 8af3fd4 Jul 23, 2024
@github-project-automation github-project-automation bot moved this from 🔧 Implementation to 🟢 Accepted in Issues Board Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-libs Libraries: New libraries to be implemented -viz
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants