Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use System.out.print in Standard.Test - use IO! #10028

Closed
JaroslavTulach opened this issue May 22, 2024 · 3 comments · Fixed by #10858
Closed

Don't use System.out.print in Standard.Test - use IO! #10028

JaroslavTulach opened this issue May 22, 2024 · 3 comments · Fixed by #10858
Assignees
Labels
-compiler -libs Libraries: New libraries to be implemented p-lowest Should be completed at some point

Comments

@JaroslavTulach
Copy link
Member

JaroslavTulach commented May 22, 2024

To invoke print we have to include java.io.PrintStream in the list of classes needed for reflective access - see #9997 (comment)

If print (instead of println) is needed, we should expose it from IO. For example:

println text:Text nl='\n' = ...

which one could invoke as IO.println nl="" "some text".

Originally posted by @JaroslavTulach in #9997 (comment)

@JaroslavTulach JaroslavTulach added the -libs Libraries: New libraries to be implemented label May 22, 2024
@jdunkerley jdunkerley added the p-lowest Should be completed at some point label Jun 19, 2024
@GregoryTravis
Copy link
Contributor

This will require a new builtin. @JaroslavTulach

@GregoryTravis GregoryTravis added this to the Future Release milestone Aug 6, 2024
@JaroslavTulach JaroslavTulach self-assigned this Aug 20, 2024
@JaroslavTulach JaroslavTulach moved this from ❓New to 📤 Backlog in Issues Board Aug 20, 2024
@JaroslavTulach JaroslavTulach moved this from 📤 Backlog to 👁️ Code review in Issues Board Aug 21, 2024
@enso-bot
Copy link

enso-bot bot commented Aug 23, 2024

Jaroslav Tulach reports a new STANDUP for yesterday (2024-08-22):

Progress: - IO.print: 5f7f8c8

Discord
Discord is great for playing games and chilling with friends, or even building a worldwide community. Customize your own space to talk, play, and hang out.
Discord
Discord is great for playing games and chilling with friends, or even building a worldwide community. Customize your own space to talk, play, and hang out.

@enso-bot
Copy link

enso-bot bot commented Aug 24, 2024

Jaroslav Tulach reports a new STANDUP for yesterday (2024-08-23):

Progress: - IO.print needs a lot of test changes: bae5b28

GitHub
Pull Request Description close #10727

Changelog:

add: implement lazy allocation of DiagnosticStorage objects
update: compiler phases to make sure they don't allocate redundant DiagnosticStora...

@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Aug 24, 2024
@AdRiley AdRiley removed this from the Future Release milestone Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-compiler -libs Libraries: New libraries to be implemented p-lowest Should be completed at some point
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants